test: add `snap-simple-keyring-site` as a local server and remove live requests to the site #36557

seaona · 2025-10-03T09:45:33Z

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-10-03T09:45:43Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-10-03T09:48:03Z

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (1 files, +1 -0)

📁 test/
- 📁 e2e/
  - 📁 tests/
    - 📁 multichain-accounts/
      - 📄 common.ts +1 -0

🫰 @MetaMask/core-platform (3 files, +2 -2)

📁 test/
- 📁 e2e/
  - 📁 mock-response-data/
    - 📁 snaps/
      - 📁 snap-binaries-and-headers/
        
        📄 [email protected]
        
        📄 [email protected] +2 -2
        
        📄 [email protected]

🧩 @MetaMask/extension-devs (5 files, +15 -25)

📁 lavamoat/
- 📁 browserify/
  - 📁 beta/
    - 📄 policy.json +1 -1
  - 📁 experimental/
    - 📄 policy.json +1 -1
  - 📁 flask/
    - 📄 policy.json +1 -1
  - 📁 main/
    - 📄 policy.json +1 -1
- 📁 build-system/
  - 📄 policy.json +11 -21

📜 @MetaMask/policy-reviewers (5 files, +15 -25)

📁 lavamoat/
- 📁 browserify/
  - 📁 beta/
    - 📄 policy.json +1 -1
  - 📁 experimental/
    - 📄 policy.json +1 -1
  - 📁 flask/
    - 📄 policy.json +1 -1
  - 📁 main/
    - 📄 policy.json +1 -1
- 📁 build-system/
  - 📄 policy.json +11 -21

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

🧪 @MetaMask/qa (2 files, +30 -21)

📁 test/
- 📁 e2e/
  - 📄 helpers.js +30 -12
  - 📄 mock-e2e-allowlist.js +0 -9

🔗 @MetaMask/supply-chain (5 files, +15 -25)

📁 lavamoat/
- 📁 browserify/
  - 📁 beta/
    - 📄 policy.json +1 -1
  - 📁 experimental/
    - 📄 policy.json +1 -1
  - 📁 flask/
    - 📄 policy.json +1 -1
  - 📁 main/
    - 📄 policy.json +1 -1
- 📁 build-system/
  - 📄 policy.json +11 -21

socket-security · 2025-10-03T09:48:17Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Quality
	@mui/core-downloads-tracker@5.18.0
	@emotion/memoize@0.9.0
	@emotion/use-insertion-effect-with-fallbacks@1.0.1 ⏵ 1.2.0	⁺¹	⁺²
	@emotion/utils@1.4.2
	json-rpc-middleware-stream@4.2.3
	@mui/types@7.2.24
	@types/react-helmet@6.1.11
	@emotion/serialize@1.3.3
	@mui/private-theming@5.17.1
	@types/prop-types@15.7.3 ⏵ 15.7.15		⁺²
	@emotion/unitless@0.7.5
	@mui/styled-engine@5.18.0
	@emotion/is-prop-valid@1.4.0
	@mui/utils@5.17.1
	acorn-import-phases@1.0.4
	@emotion/weak-memoize@0.4.0
	css-color-keywords@1.0.0
	find-root@1.1.0
	shallowequal@1.1.0
	camelize@1.0.1
	babel-plugin-macros@3.1.0
	react-side-effect@2.1.2
	@mui/system@5.18.0
	babel-plugin-styled-components@2.1.4
	css-to-react-native@3.2.0
	stylis@4.2.0
	@emotion/styled@11.14.1
	json-rpc-engine@6.1.0
	watchpack@2.4.1 ⏵ 2.4.4	⁺¹
	@emotion/stylis@0.8.5
	@emotion/sheet@1.4.0
	react-helmet@6.1.0
	@emotion/babel-plugin@11.13.5
See 13 more rows in the dashboard

View full report

socket-security · 2025-10-03T09:48:19Z

Caution

MetaMask internal reviewing guidelines:

Do not ignore-all
Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
@SocketSecurity ignore npm/PACKAGE@VERSION

Action	Severity	Alert (click "▶" to expand/collapse)
Block		`@emotion/[email protected]` has a New author. New Author: emotion-release-bot Previous Author: mitchellhamilton From: yarn.lock → `npm/@emotion/[email protected]` ℹ Read more on: This package \| This alert \| What is new author? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/@emotion/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Block		`@emotion/[email protected]` has a New author. New Author: emotion-release-bot Previous Author: mitchellhamilton From: yarn.lock → `npm/@emotion/[email protected]` ℹ Read more on: This package \| This alert \| What is new author? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/@emotion/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Block		`@metamask/[email protected]` has a New author. New Author: lgbot Previous Author: gudahtt From: yarn.lock → `npm/@metamask/[email protected]` → `npm/@metamask/[email protected]` ℹ Read more on: This package \| This alert \| What is new author? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/@metamask/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Block		`[email protected]` has a New author. New Author: ljharb Previous Author: substack From: yarn.lock → `npm/[email protected]` ℹ Read more on: This package \| This alert \| What is new author? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Block		`[email protected]` has a New author. New Author: gudahtt Previous Author: rekmarks From: yarn.lock → `npm/@metamask/[email protected]` → `npm/[email protected]` ℹ Read more on: This package \| This alert \| What is new author? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Block		`[email protected]` has a New author. New Author: jsdnxx Previous Author: jden From: yarn.lock → `npm/[email protected]` ℹ Read more on: This package \| This alert \| What is new author? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		`@emotion/[email protected]` is a AI-detected potential code anomaly. Notes: Overall, this is a standard, non-malicious portion of the Emotion styling library. No evidence of backdoors, credential theft, or external network/data exfiltration. The primary risk vector is the CSS-in-DOM injection path via dangerouslySetInnerHTML, which is expected but should be reviewed in the context of trusted inputs. Security posture is low-to-moderate; no immediate danger, but maintain caution with user-supplied template literals and ensure dependencies are trusted. Confidence: 1.00 Severity: 0.60 From: yarn.lock → `npm/@emotion/[email protected]` ℹ Read more on: This package \| This alert \| What is an AI-detected potential code anomaly? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/@emotion/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

seaona · 2025-10-03T10:14:10Z

test/e2e/mock-e2e-allowlist.js

-  'https://metamask.github.io/snap-simple-keyring/1.1.6/framework-fe667a09be4a08a9b5f4.js',
-  'https://metamask.github.io/snap-simple-keyring/1.1.6/page-data/app-data.json',
-  'https://metamask.github.io/snap-simple-keyring/1.1.6/page-data/index/page-data.json',
-  'https://metamask.github.io/snap-simple-keyring/1.1.6/webpack-runtime-f26b9ef4aabef2136bf7.js',


less live requests in our e2e, yay! 🎉

seaona · 2025-10-03T10:15:24Z

test/e2e/mock-response-data/snaps/snap-binaries-and-headers/[email protected]

ℹ️ the snap file binary changes are just the result of updating the snap package, by running this command: yarn update-snap-binary [email protected]

seaona · 2025-10-03T10:16:06Z

test/e2e/page-objects/flows/snap-simple-keyring.flow.ts

 export async function installSnapSimpleKeyring(
  driver: Driver,
  isSyncFlow: boolean = true,
+  port: number = 8080,


ℹ️ we add this new param, to avoid port collisions in the case we need to use both the test dapp and the snap simple keyring page

seaona · 2025-10-03T10:16:46Z

package.json

    "@metamask/foundryup": "^1.0.1",
    "@metamask/phishing-warning": "^5.0.1",
    "@metamask/preferences-controller": "^19.0.0",
+    "@metamask/snap-simple-keyring-site": "^2.0.0",


ℹ️ we can now use the npm package

MetaMask/snap-simple-keyring#163

Context: The update to 2.0.0 doesn't change anything on the snap-simple-keyring. It's a major update, because we have made the snap-simple-keyring-site publishable, in order to use it in our e2e as a local server. See more here: - MetaMask/snap-simple-keyring#163 - MetaMask/metamask-extension#36557

seaona · 2025-10-03T13:00:20Z

@metamaskbot update-policies

metamaskbot · 2025-10-03T13:16:27Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-10-03T13:32:03Z

❌ test-e2e-chrome-api-specs failed. View the html report here.

metamaskbot · 2025-10-03T13:42:43Z

📊 Page Load Benchmark Results

Current Commit: 2ae9ae5 | Date: 10/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±72ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
domContentLoaded-> current mean value: 735ms (±69ms) 🟢 | historical mean value: 741ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±14ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	72ms	1.01s	1.34s	1.29s	1.34s
domContentLoaded	735ms	69ms	700ms	1.00s	944ms	1.00s
firstPaint	77ms	14ms	60ms	204ms	84ms	204ms
firstContentfulPaint	77ms	14ms	60ms	204ms	84ms	204ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-03T13:42:49Z

Builds ready [2ae9ae5]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1243 ± 72 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1243	1107	1414	72	1292	1362
			load	1073	965	1201	63	1119	1193
			domContentLoaded	1065	960	1197	64	1108	1187
			domInteractive	18	13	63	8	17	33
			firstPaint	603	142	1199	428	1065	1139
			backgroundConnect	255	239	335	12	257	273
			firstReactRender	24	16	65	8	25	42
			getState	12	5	86	9	12	24
			initialActions	5	0	72	9	6	14
			loadScripts	818	716	944	62	851	940
			setupStore	9	6	31	4	9	15
	Webpack	Home	uiStartup	2025	1431	2635	286	2238	2493
			load	1621	1133	2042	221	1750	1981
			domContentLoaded	1614	1128	2031	219	1741	1962
			domInteractive	19	12	96	16	15	58
			firstPaint	170	66	359	67	199	316
			backgroundConnect	27	16	76	10	30	45
			firstReactRender	96	38	339	76	87	326
			getState	23	4	294	53	14	62
			initialActions	6	2	22	4	6	18
			loadScripts	1610	1124	2020	218	1737	1951
			setupStore	19	5	281	41	14	26
Firefox	Browserify	Home	uiStartup	1415	1206	1842	116	1483	1625
			load	1216	1051	1389	82	1291	1354
			domContentLoaded	1216	1051	1389	82	1291	1354
			domInteractive	104	35	393	54	115	223
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	19	150	22	33	77
			firstReactRender	29	24	74	8	30	44
			getState	10	3	168	20	6	48
			initialActions	5	1	158	16	3	10
			loadScripts	1190	1026	1372	83	1265	1332
			setupStore	10	5	55	9	8	29
	Webpack	Home	uiStartup	1590	1408	2006	148	1699	1880
			load	1354	1181	1701	132	1430	1614
			domContentLoaded	1353	1181	1700	132	1430	1613
			domInteractive	109	35	342	64	106	313
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	20	69	8	37	45
			firstReactRender	38	32	51	4	41	44
			getState	6	3	19	2	6	11
			initialActions	3	1	15	2	3	5
			loadScripts	1331	1153	1681	132	1410	1590
			setupStore	10	6	137	13	9	16

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 54 Bytes (0%)
ui: 612 Bytes (0.01%)
common: 72 Bytes (0%)

seaona · 2025-10-03T15:17:46Z

@metamaskbot update-policies

metamaskbot · 2025-10-03T15:33:41Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-10-03T16:39:05Z

📊 Page Load Benchmark Results

Current Commit: 42b02d0 | Date: 10/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±75ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 740ms (±71ms) 🟢 | historical mean value: 741ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	75ms	1.01s	1.33s	1.32s	1.33s
domContentLoaded	740ms	71ms	701ms	1.01s	978ms	1.01s
firstPaint	77ms	11ms	60ms	168ms	88ms	168ms
firstContentfulPaint	77ms	11ms	60ms	168ms	88ms	168ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-03T16:39:17Z

Builds ready [42b02d0]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1252 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1252	1141	1568	71	1283	1397
			load	1077	983	1384	62	1105	1183
			domContentLoaded	1069	978	1376	61	1099	1175
			domInteractive	18	14	43	6	18	37
			firstPaint	652	82	1249	428	1083	1159
			backgroundConnect	256	241	279	7	260	272
			firstReactRender	25	16	47	6	27	39
			getState	12	5	51	7	15	28
			initialActions	5	1	54	7	6	14
			loadScripts	820	730	1110	59	851	925
			setupStore	10	6	32	4	10	19
	Webpack	Home	uiStartup	1827	1571	2164	142	1929	2089
			load	1502	1368	1749	88	1563	1667
			domContentLoaded	1488	1355	1735	87	1542	1659
			domInteractive	17	11	81	13	13	50
			firstPaint	244	54	1629	379	184	1512
			backgroundConnect	33	17	64	11	39	56
			firstReactRender	48	18	186	25	52	95
			getState	12	5	21	4	14	20
			initialActions	4	0	36	7	3	24
			loadScripts	1484	1353	1732	87	1531	1657
			setupStore	15	4	157	23	13	36
Firefox	Browserify	Home	uiStartup	1406	1255	1779	99	1457	1608
			load	1213	1092	1439	72	1277	1332
			domContentLoaded	1213	1092	1439	72	1276	1332
			domInteractive	101	32	316	52	99	243
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	18	134	16	33	53
			firstReactRender	29	24	58	5	30	40
			getState	8	3	135	14	6	13
			initialActions	3	0	22	3	3	8
			loadScripts	1190	1072	1406	72	1254	1313
			setupStore	9	5	82	10	8	26
	Webpack	Home	uiStartup	1516	1320	2006	118	1578	1715
			load	1324	1178	1673	87	1373	1501
			domContentLoaded	1324	1177	1673	87	1373	1501
			domInteractive	97	29	381	59	100	199
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	17	108	14	36	61
			firstReactRender	34	24	144	17	33	75
			getState	9	3	119	17	6	14
			initialActions	5	1	51	8	3	15
			loadScripts	1299	1161	1645	85	1342	1475
			setupStore	14	5	215	26	9	48

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 65 Bytes (0%)
ui: 616 Bytes (0.01%)
common: 82 Bytes (0%)

simple keyring local server

2e2e742

seaona self-assigned this Oct 3, 2025

seaona added flaky tests skip-e2e-quality-gate no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed e2e-maintenance labels Oct 3, 2025

metamaskbot added the team-qa QA team label Oct 3, 2025

github-actions bot added the size-S label Oct 3, 2025

seaona mentioned this pull request Oct 3, 2025

Add snap-simple-keyring v2.0.0 to the allowlist MetaMask/snaps-registry#1358

Merged

seaona commented Oct 3, 2025

View reviewed changes

seaona changed the title ~~test: add snap-simple-keyring-site as a local server~~ test: add snap-simple-keyring-site as a local server and remove live requests to the site Oct 3, 2025

proxy

ddfae71

github-actions bot added size-M and removed size-S labels Oct 3, 2025

rmv true

5b322f0

Update LavaMoat policies

2ae9ae5

Merge branch 'main' into test-snap-simple-keyring

5fae7cd

seaona added 2 commits October 3, 2025 17:06

fix

e149e1d

rmv extre dapp

6344fa5

Update LavaMoat policies

0e0a79b

Merge branch 'main' into test-snap-simple-keyring

42b02d0

test: add snap-simple-keyring-site as a local server and remove live requests to the site #36557

Are you sure you want to change the base?

test: add snap-simple-keyring-site as a local server and remove live requests to the site #36557

Conversation

seaona commented Oct 3, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 3, 2025

Uh oh!

metamaskbot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

socket-security bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seaona Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

seaona Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seaona Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

seaona Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

seaona commented Oct 3, 2025

Uh oh!

metamaskbot commented Oct 3, 2025

Uh oh!

metamaskbot commented Oct 3, 2025

Uh oh!

metamaskbot commented Oct 3, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 3, 2025

Uh oh!

seaona commented Oct 3, 2025

Uh oh!

metamaskbot commented Oct 3, 2025

Uh oh!

metamaskbot commented Oct 3, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 3, 2025

Uh oh!

Uh oh!

test: add `snap-simple-keyring-site` as a local server and remove live requests to the site #36557

test: add `snap-simple-keyring-site` as a local server and remove live requests to the site #36557

seaona commented Oct 3, 2025 •

edited by github-actions bot

Loading

metamaskbot commented Oct 3, 2025 •

edited

Loading

socket-security bot commented Oct 3, 2025 •

edited

Loading

socket-security bot commented Oct 3, 2025 •

edited

Loading

seaona Oct 3, 2025 •

edited

Loading