fix: Refine slippage buttons to match trade patterns #36556
Merged
+32
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🔄 @MetaMask/swaps-engineers (2 files, +32 -84)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [8d9f4c2]
UI Startup Metrics (1230 ± 65 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [bf01e69]
UI Startup Metrics (1230 ± 62 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| : `${customSlippage}%`} | ||
| </Text> | ||
| </Button> | ||
| <> |
There was a problem hiding this comment.
Can we not use the variant prop way so we can prevent duplicating logic by having only a single button component?
There was a problem hiding this comment.
Noted, thanks for the suggestion!
I've updated the code to conditionally render the buttons using the variant prop. Now the logic is not duplicated.
micaelae
reviewed
Oct 10, 2025
| !isAutoSelected && localSlippage === hardcodedSlippage; | ||
| return ( | ||
| <Button | ||
| isAutoSelected === false && localSlippage === hardcodedSlippage; |
There was a problem hiding this comment.
@amandaye0h I agree with Cursor here. can you change this to check for !isAutoSelected instead?
There was a problem hiding this comment.
Noted, I reverted the change:
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [e3c0ea8]
UI Startup Metrics (1262 ± 84 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
amandaye0h
added
the
team-design-system
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [d039c94]
UI Startup Metrics (1274 ± 85 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
approved these changes
Oct 23, 2025
bfullam
approved these changes
Oct 29, 2025
metamaskbot
added
the
release-13.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the slippage buttons to follow the Trade UI selection patterns used in our Mobile app. It improves cross-client consistency by replacing the old logic with
ButtonSecondary, ensuring the buttons inherit design system standards.Changelog
CHANGELOG entry: null: UI fixes
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2025-10-08.at.4.17.09.PM.mov
After
Screen.Recording.2025-10-03.at.3.57.37.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Refactors bridge slippage controls to use design-system Button variants/sizes and simplifies text field styling.
ui/pages/bridge/prepare/bridge-transaction-settings-modal.tsx):ButtonPrimarysubmit withButton(ButtonVariant.Primary,ButtonSize.Lg).ButtonSize.Mdand useButtonVariant.Primary/Secondaryfor selected state; remove manual border/background/text color logic.TextwithvariantbodyMdMedium; adjust container padding (paddingInline,paddingBottom).TextField: setsizetoMd,borderColortoborderMuted,borderRadiustoXL; remove explicit border width.ui/pages/bridge/prepare/index.scss):.bridge-settings-modal .mm-text-field: remove fixed heights and input font-size/padding; keep width; maintain secondary button hover style.Written by Cursor Bugbot for commit d039c94. This will update automatically on new commits. Configure here.