Skip to content

Conversation

@ghgoodreau
Copy link
Contributor

@ghgoodreau ghgoodreau commented Oct 2, 2025

Description

Removes the network conditions for the swap button because of BIP44.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Swaps buttons should now be enabled regardless of network you're on.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Oct 2, 2025
@github-actions github-actions bot added the size-M label Oct 2, 2025
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 407d571 | Date: 10/2/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±71ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 731ms (±84ms) 🟢 | historical mean value: 739ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±43ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 71ms 1.00s 1.32s 1.27s 1.32s
domContentLoaded 731ms 84ms 696ms 1.28s 932ms 1.28s
firstPaint 79ms 43ms 56ms 496ms 88ms 496ms
firstContentfulPaint 79ms 43ms 56ms 496ms 88ms 496ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [407d571]
UI Startup Metrics (1228 ± 67 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1228111113836712841328
load106194312306311151156
domContentLoaded105493712216311091149
domInteractive17134871737
firstPaint634134122742710761134
backgroundConnect2522372798256266
firstReactRender23164662340
getState13596111428
initialActions51798613
loadScripts80968297762864897
setupStore95263917
WebpackHomeuiStartup19491489256028921832461
load15681203191722017351893
domContentLoaded15611196190321917301877
domInteractive171282121445
firstPaint1596341167187294
backgroundConnect261264102854
firstReactRender85373296577277
getState2652866213268
initialActions52223610
loadScripts15571193189121717271866
setupStore175288401224
FirefoxBrowserifyHomeuiStartup14721271187112315281753
load1261110215998813311411
domContentLoaded1260110215998813311410
domInteractive1083639762111250
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3420147193653
firstReactRender29245043036
getState9313216718
initialActions511801839
loadScripts1235108615788813041388
setupStore145175251048
WebpackHomeuiStartup15611361188613116621836
load13291151159812114231575
domContentLoaded13291151159812114231575
domInteractive1013431049105221
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect30197983639
firstReactRender37316043944
getState63234617
initialActions4067939
loadScripts13071124157612214031555
setupStore10513113923

@ghgoodreau ghgoodreau closed this Oct 24, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-M team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants