feat: Add param to `MetamaskController.privateSendUpdate` for only sending pending patches #36536

MajorLift · 2025-10-02T16:52:30Z

Description

The MetamaskController.privateSendUpdate method is currently not used anywhere, but is a useful wrapper for the uncommon scenario where a forced UI state update needs to be triggered in response to background events or actions. In the more usual case where a UI state update needs to be triggered in response to user actions, forceUpdateMetamaskState is used.

This commit adds a boolean flag parameter to privateSendUpdate for optionally triggering state updates only with pending patches, which is the default behavior of the update event that is used by the method.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

privateSendUpdate now accepts a sendFullState flag to either emit the full MetaMask state or just trigger an 'update' for pending patches, with updated JSDoc.

^{Written by Cursor Bugbot for commit 0727256. This will update automatically on new commits. Configure here.}

github-actions · 2025-10-02T16:52:39Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-10-02T17:18:34Z

📊 Page Load Benchmark Results

Current Commit: 8de082b | Date: 10/2/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.08s (±77ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 756ms (±73ms) 🟢 | historical mean value: 739ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±12ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.08s	77ms	1.03s	1.36s	1.34s	1.36s
domContentLoaded	756ms	73ms	708ms	1.04s	998ms	1.04s
firstPaint	80ms	12ms	68ms	184ms	96ms	184ms
firstContentfulPaint	80ms	12ms	68ms	184ms	96ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-02T17:18:41Z

Builds ready [8de082b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1286 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1286	1136	1465	63	1319	1409
			load	1109	972	1258	62	1142	1232
			domContentLoaded	1101	966	1252	62	1134	1220
			domInteractive	18	14	45	6	17	39
			firstPaint	631	160	1244	451	1123	1216
			backgroundConnect	261	244	297	9	265	278
			firstReactRender	25	18	48	7	26	41
			getState	13	5	60	8	16	25
			initialActions	5	0	75	8	6	14
			loadScripts	848	714	994	62	880	967
			setupStore	9	6	31	3	10	13
	Webpack	Home	uiStartup	2101	1568	2710	261	2290	2544
			load	1671	1249	2169	209	1833	1987
			domContentLoaded	1663	1237	2146	208	1826	1970
			domInteractive	19	12	151	20	15	47
			firstPaint	167	69	629	82	194	298
			backgroundConnect	28	17	75	11	31	54
			firstReactRender	107	39	338	86	99	329
			getState	25	5	287	58	15	267
			initialActions	6	2	40	5	6	16
			loadScripts	1659	1232	2136	207	1822	1958
			setupStore	33	5	411	77	15	294
Firefox	Browserify	Home	uiStartup	1396	1217	1749	107	1443	1638
			load	1208	1050	1519	86	1264	1364
			domContentLoaded	1208	1050	1519	86	1264	1363
			domInteractive	110	32	413	62	110	262
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	18	95	14	34	69
			firstReactRender	28	24	72	5	29	34
			getState	8	3	75	11	6	13
			initialActions	3	0	43	4	3	7
			loadScripts	1183	1032	1497	87	1240	1322
			setupStore	9	5	52	7	8	24
	Webpack	Home	uiStartup	1640	1445	2053	159	1747	1963
			load	1388	1211	1727	134	1486	1651
			domContentLoaded	1388	1211	1727	134	1485	1651
			domInteractive	117	35	403	67	116	317
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	21	60	7	38	45
			firstReactRender	39	33	82	5	41	46
			getState	8	3	166	16	6	14
			initialActions	5	1	118	15	3	8
			loadScripts	1365	1191	1706	135	1463	1632
			setupStore	13	6	156	17	10	41

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 240 Bytes (0.01%)
ui: 7.32 KiB (0.11%)
common: 2.16 KiB (0.03%)

metamaskbot · 2025-10-03T15:28:40Z

📊 Page Load Benchmark Results

Current Commit: d7f6f88 | Date: 10/2/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±72ms) 🟡 | historical mean value: 1.06s ⬆️ (historical data)
domContentLoaded-> current mean value: 748ms (±70ms) 🟢 | historical mean value: 741ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	72ms	1.03s	1.34s	1.29s	1.34s
domContentLoaded	748ms	70ms	712ms	1.01s	960ms	1.01s
firstPaint	78ms	12ms	60ms	188ms	92ms	188ms
firstContentfulPaint	78ms	12ms	60ms	188ms	92ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-03T15:28:47Z

Builds ready [d7f6f88]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1215 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1215	1086	1404	64	1264	1317
			load	1050	959	1194	56	1098	1141
			domContentLoaded	1043	947	1186	57	1091	1135
			domInteractive	17	13	51	7	16	39
			firstPaint	645	115	1159	422	1059	1137
			backgroundConnect	251	238	282	8	255	265
			firstReactRender	22	17	42	4	23	31
			getState	13	5	74	9	16	27
			initialActions	5	0	61	8	5	11
			loadScripts	799	707	924	55	846	895
			setupStore	9	6	27	3	10	17
	Webpack	Home	uiStartup	1985	1565	2555	264	2173	2455
			load	1585	1243	1968	203	1728	1902
			domContentLoaded	1578	1231	1964	203	1719	1892
			domInteractive	16	12	64	9	14	42
			firstPaint	166	71	375	60	190	298
			backgroundConnect	28	12	70	10	31	52
			firstReactRender	99	36	340	81	90	327
			getState	34	4	308	75	14	270
			initialActions	5	2	21	3	6	12
			loadScripts	1574	1229	1953	201	1717	1880
			setupStore	16	5	272	37	13	23
Firefox	Browserify	Home	uiStartup	1512	1299	2060	120	1557	1715
			load	1301	1131	1617	85	1361	1445
			domContentLoaded	1300	1131	1617	85	1361	1445
			domInteractive	116	35	479	72	122	273
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	36	21	148	22	39	98
			firstReactRender	30	25	52	4	32	36
			getState	11	3	233	29	7	25
			initialActions	4	1	14	2	4	10
			loadScripts	1273	1115	1600	84	1336	1420
			setupStore	10	6	52	7	10	28
	Webpack	Home	uiStartup	1682	1445	2266	151	1785	1966
			load	1426	1242	1742	131	1523	1668
			domContentLoaded	1425	1242	1742	131	1523	1667
			domInteractive	117	73	350	59	118	300
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	35	22	95	9	41	47
			firstReactRender	40	33	50	3	42	46
			getState	8	3	134	15	7	14
			initialActions	5	1	205	20	3	6
			loadScripts	1400	1215	1713	132	1492	1642
			setupStore	10	6	39	6	10	27

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 240 Bytes (0.01%)
ui: 7.32 KiB (0.11%)
common: 2.19 KiB (0.03%)

metamaskbot · 2025-10-03T16:00:24Z

📊 Page Load Benchmark Results

Current Commit: 0727256 | Date: 10/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±73ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 754ms (±70ms) 🟢 | historical mean value: 740ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±11ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	73ms	1.03s	1.37s	1.29s	1.37s
domContentLoaded	754ms	70ms	716ms	1.04s	961ms	1.04s
firstPaint	79ms	11ms	64ms	176ms	88ms	176ms
firstContentfulPaint	79ms	11ms	64ms	176ms	88ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-03T16:00:38Z

Builds ready [0727256]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1224 ± 56 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1224	1114	1386	56	1256	1349
			load	1061	962	1203	52	1092	1152
			domContentLoaded	1053	949	1194	53	1085	1140
			domInteractive	18	13	62	8	17	37
			firstPaint	702	98	1194	420	1077	1133
			backgroundConnect	254	241	279	8	257	273
			firstReactRender	24	17	45	6	25	38
			getState	12	5	94	9	14	22
			initialActions	4	0	18	3	5	10
			loadScripts	807	710	940	51	836	892
			setupStore	9	5	27	3	10	17
	Webpack	Home	uiStartup	1826	1549	2283	190	1983	2157
			load	1516	1361	1805	127	1603	1760
			domContentLoaded	1504	1349	1797	126	1595	1743
			domInteractive	16	11	89	14	13	47
			firstPaint	205	57	1690	310	175	1376
			backgroundConnect	31	15	168	18	35	55
			firstReactRender	45	19	184	24	54	81
			getState	12	5	110	11	13	19
			initialActions	3	0	20	3	3	11
			loadScripts	1500	1347	1795	125	1590	1738
			setupStore	12	3	106	11	14	23
Firefox	Browserify	Home	uiStartup	1390	1247	1768	119	1433	1658
			load	1190	1083	1386	79	1232	1349
			domContentLoaded	1189	1083	1385	79	1232	1349
			domInteractive	96	34	287	51	98	240
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	29	20	67	10	33	51
			firstReactRender	29	25	47	4	31	38
			getState	8	3	60	10	7	24
			initialActions	3	1	21	3	3	7
			loadScripts	1168	1068	1359	76	1210	1322
			setupStore	12	5	162	22	8	35
	Webpack	Home	uiStartup	1607	1419	2175	142	1656	1952
			load	1395	1225	1781	104	1440	1673
			domContentLoaded	1395	1225	1780	104	1440	1672
			domInteractive	102	32	400	70	98	350
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	40	20	139	22	43	94
			firstReactRender	35	26	165	16	36	57
			getState	8	3	101	11	7	17
			initialActions	4	1	48	7	4	15
			loadScripts	1364	1207	1762	98	1406	1556
			setupStore	15	4	117	21	10	75

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 458 Bytes (0.01%)
ui: 8.25 KiB (0.13%)
common: 2.32 KiB (0.03%)

… pending patches

metamaskbot · 2025-10-07T13:04:05Z

📊 Page Load Benchmark Results

Current Commit: e6106f0 | Date: 10/7/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±72ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 743ms (±70ms) 🟢 | historical mean value: 736ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±11ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	72ms	1.02s	1.34s	1.29s	1.34s
domContentLoaded	743ms	70ms	709ms	1.02s	964ms	1.02s
firstPaint	79ms	11ms	60ms	172ms	88ms	172ms
firstContentfulPaint	79ms	11ms	60ms	172ms	88ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-07T13:04:12Z

Builds ready [e6106f0]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1245 ± 76 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1245	1090	1545	76	1282	1382
			load	1078	932	1330	76	1115	1226
			domContentLoaded	1072	926	1312	76	1112	1220
			domInteractive	17	13	49	6	16	36
			firstPaint	708	144	1337	436	1086	1195
			backgroundConnect	251	238	278	7	255	265
			firstReactRender	25	17	132	16	23	41
			getState	11	5	33	6	13	27
			initialActions	4	0	22	4	4	14
			loadScripts	827	677	1045	75	869	972
			setupStore	9	5	31	5	9	21
	Webpack	Home	uiStartup	1897	1554	2277	193	2046	2209
			load	1561	1380	1901	127	1649	1786
			domContentLoaded	1546	1369	1858	125	1633	1776
			domInteractive	18	11	97	17	14	68
			firstPaint	335	59	1781	497	197	1631
			backgroundConnect	33	14	90	14	41	63
			firstReactRender	52	19	235	32	62	109
			getState	15	3	136	19	15	28
			initialActions	5	0	159	17	3	24
			loadScripts	1541	1367	1856	124	1629	1774
			setupStore	12	4	38	7	15	31
Firefox	Browserify	Home	uiStartup	1440	1250	1800	121	1489	1741
			load	1235	1075	1548	91	1299	1395
			domContentLoaded	1234	1074	1548	92	1299	1395
			domInteractive	106	36	443	68	98	257
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	31	20	116	12	35	53
			firstReactRender	30	25	52	5	32	42
			getState	6	3	28	4	6	12
			initialActions	4	1	37	6	2	15
			loadScripts	1212	1058	1534	90	1268	1374
			setupStore	11	4	141	19	7	51
	Webpack	Home	uiStartup	1590	1352	2140	141	1614	1955
			load	1379	1204	1766	99	1420	1579
			domContentLoaded	1378	1204	1765	99	1420	1579
			domInteractive	107	32	413	74	105	363
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	35	19	109	18	38	86
			firstReactRender	36	26	82	14	36	78
			getState	8	3	68	10	6	30
			initialActions	7	0	129	17	2	41
			loadScripts	1351	1187	1740	95	1390	1555
			setupStore	9	3	59	11	7	46

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 226 Bytes (0%)
ui: 0 Bytes (0%)
common: 10 Bytes (0%)

metamaskbot added the team-extension-platform Extension Platform team label Oct 2, 2025

github-actions bot added the size-S label Oct 2, 2025

MajorLift force-pushed the jongsun/feat/251002-add-param-to-privateSendUpdate branch from 8de082b to d7f6f88 Compare October 2, 2025 17:31

MajorLift added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Oct 3, 2025

MajorLift added this to PR review queue Oct 3, 2025

github-project-automation bot moved this to Needs dev review in PR review queue Oct 3, 2025

MajorLift marked this pull request as ready for review October 3, 2025 15:32

MajorLift force-pushed the jongsun/feat/251002-add-param-to-privateSendUpdate branch from 920a2f1 to 0727256 Compare October 3, 2025 15:34

MajorLift removed the status in PR review queue Oct 3, 2025

MajorLift marked this pull request as draft October 3, 2025 17:43

Add option to MetamaskController.privateSendUpdate for only sending…

c6731fd

… pending patches

MajorLift force-pushed the jongsun/feat/251002-add-param-to-privateSendUpdate branch from 0727256 to a4c55a2 Compare October 7, 2025 12:32

Add logic for handling missing payloads to 'update' event listeners

e6106f0

MajorLift force-pushed the jongsun/feat/251002-add-param-to-privateSendUpdate branch from a4c55a2 to e6106f0 Compare October 7, 2025 12:38

MajorLift closed this Oct 8, 2025

github-actions bot locked and limited conversation to collaborators Oct 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add param to `MetamaskController.privateSendUpdate` for only sending pending patches #36536

feat: Add param to `MetamaskController.privateSendUpdate` for only sending pending patches #36536

MajorLift commented Oct 2, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

metamaskbot commented Oct 2, 2025

Uh oh!

metamaskbot commented Oct 2, 2025

Uh oh!

metamaskbot commented Oct 3, 2025

Uh oh!

metamaskbot commented Oct 3, 2025

Uh oh!

metamaskbot commented Oct 3, 2025

Uh oh!

metamaskbot commented Oct 3, 2025

Uh oh!

metamaskbot commented Oct 7, 2025

Uh oh!

metamaskbot commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: Add param to MetamaskController.privateSendUpdate for only sending pending patches #36536

feat: Add param to MetamaskController.privateSendUpdate for only sending pending patches #36536

Conversation

MajorLift commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

metamaskbot commented Oct 2, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 2, 2025

Uh oh!

metamaskbot commented Oct 3, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 3, 2025

Uh oh!

metamaskbot commented Oct 3, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 3, 2025

Uh oh!

metamaskbot commented Oct 7, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: Add param to `MetamaskController.privateSendUpdate` for only sending pending patches #36536

feat: Add param to `MetamaskController.privateSendUpdate` for only sending pending patches #36536

MajorLift commented Oct 2, 2025 •

edited

Loading