test: clean up confirmations integration tests

[cryptotavares]

Description

This PR remove unnecessary mocking dependencies. The main changes focus on standardizing how token details are handled in tests by removing the useAssetDetails mock and instead relying on the background service methods (getTokenStandardAndDetails and getTokenStandardAndDetailsByChain) with a standardized decimal value of '4'. Additionally, this PR addresses several minor issues including missing React keys, console log cleanup, and prop type adjustments

Changes

• Test Infrastructure: Added a polyfill for structuredClone using Node's v8 module to support integration tests
• Mock Removal: Eliminated useAssetDetails mocks from 15 test files, simplifying test setup and maintenance
• Token Decimals Standardization: Unified all test token decimal values to '4' for consistency
• React Warning Fix: Added proper Fragment keys in simulation-details.tsx to resolve React iterator warnings
• Prop Type Fix: Made isSigningQRHardwareTransaction optional in home.component.js as it's no longer always required
• Code Cleanup: Removed stray console.log statement from tests

Changelog

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Refactors confirmation integration tests to drop useAssetDetails mocks and standardize token decimals, adds a global structuredClone for tests, fixes SimulationDetails list keying, and makes a Home prop optional.

• Tests (Confirmations):
  • Remove useAssetDetails mocks; rely on background getTokenStandardAndDetails/getTokenStandardAndDetailsByChain with decimals: '4'.
  • Update setup helpers/mocks accordingly; tweak expectations; remove stray console.log.
• Test Setup:
  • Add v8-based structuredClone implementation and assign to global.
• UI:
  • ui/pages/confirmations/.../simulation-details.tsx: wrap mapped rows in Fragment with a key to fix list keying.
  • ui/pages/home/home.component.js: make isSigningQRHardwareTransaction PropTypes optional.

^{Written by Cursor Bugbot for commit ccd5433. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[cursor]

Bug: Component Duplication in Mapping Loop

The BalanceChangesAlert component is rendered inside the staticRows.map() loop. This causes it to appear multiple times, which can lead to duplicate alerts or unexpected behavior.

 

[metamaskbot]

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (1 files, +3 -4)

• 📁 ui/
  • 📁 pages/
    • 📁 confirmations/
      • 📁 components/
        • 📁 simulation-details/
          • 📄 simulation-details.tsx +3 -4

---

👨‍🔧 @MetaMask/core-extension-ux (1 files, +1 -1)

• 📁 ui/
  • 📁 pages/
    • 📁 home/
      • 📄 home.component.js +1 -1

[metamaskbot]

📊 Page Load Benchmark Results

Current Commit: ccd5433 | Date: 10/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.05s (±73ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
• domContentLoaded-> current mean value: 736ms (±71ms) 🟢 | historical mean value: 741ms ⬇️ (historical data)
• firstContentfulPaint-> current mean value: 77ms (±13ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	73ms	1.00s	1.32s	1.26s	1.32s
domContentLoaded	736ms	71ms	696ms	997ms	951ms	997ms
firstPaint	77ms	13ms	60ms	172ms	92ms	172ms
firstContentfulPaint	77ms	13ms	60ms	172ms	92ms	172ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

---

Results generated automatically by MetaMask CI

[metamaskbot]

Builds ready [ccd5433]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1254 ± 76 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1254	1112	1477	76	1314	1395
			load	1085	967	1276	70	1132	1203
			domContentLoaded	1078	963	1267	69	1125	1196
			domInteractive	18	13	43	7	17	40
			firstPaint	634	72	1275	444	1075	1202
			backgroundConnect	255	242	275	6	260	266
			firstReactRender	24	16	65	8	24	39
			getState	12	5	52	7	14	26
			initialActions	6	0	75	11	5	22
			loadScripts	829	715	1000	69	878	946
			setupStore	10	6	39	5	10	17
	Webpack	Home	uiStartup	2024	1540	2598	266	2180	2523
			load	1647	1249	1992	206	1780	1967
			domContentLoaded	1638	1239	1962	205	1770	1956
			domInteractive	19	12	78	15	15	67
			firstPaint	169	63	361	65	197	318
			backgroundConnect	28	13	69	12	30	52
			firstReactRender	91	38	343	74	83	319
			getState	29	5	319	68	13	271
			initialActions	5	2	29	4	6	12
			loadScripts	1634	1236	1952	203	1767	1944
			setupStore	19	5	292	43	14	25
Firefox	Browserify	Home	uiStartup	1603	1382	1947	120	1679	1884
			load	1375	1200	1593	89	1446	1542
			domContentLoaded	1375	1199	1593	89	1446	1542
			domInteractive	117	38	365	64	116	281
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	39	23	149	23	38	88
			firstReactRender	33	27	57	5	35	43
			getState	9	4	171	17	8	12
			initialActions	4	2	61	6	4	7
			loadScripts	1346	1181	1567	88	1419	1512
			setupStore	14	6	148	18	11	46
	Webpack	Home	uiStartup	1582	1369	2100	149	1693	1881
			load	1346	1157	1621	124	1458	1547
			domContentLoaded	1345	1157	1620	124	1458	1546
			domInteractive	108	32	329	61	108	298
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	21	102	9	37	41
			firstReactRender	38	32	57	4	40	45
			getState	9	3	137	18	7	15
			initialActions	4	1	82	8	3	11
			loadScripts	1322	1127	1594	126	1440	1529
			setupStore	10	5	154	15	9	24

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 58 Bytes (0%)
• ui: -22 Bytes (0%)
• common: 10 Bytes (0%)