fix: update migration 105.ts to keep internal account scopes #36505
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
team-assets
INVALID-PR-TEMPLATE
Prithpal-Sooriya
commented
Oct 1, 2025
Comment on lines
-20
to
-21
| // omit the new field to re-use the original type for that migration. | ||
| export type InternalAccountV1 = Omit<InternalAccount, 'scopes'>; |
There was a problem hiding this comment.
This is interesting. From the sounds of it, it seems like the original type when this migration was made did not have the scopes property.
But it doesn't look like any of our other migrations adds back this property (meaning older users who migrate / our e2e tests) never receive a scopes property?
Prithpal-Sooriya
commented
Oct 1, 2025
| }, | ||
| methods: ETH_EOA_METHODS, | ||
| type: EthAccountType.Eoa, | ||
| scopes: [EthScope.Eoa], |
There was a problem hiding this comment.
Rather than omitting the Scopes property, we are defaulting to the Eth EOA scope (similar to the Eth EOA type).
Prithpal-Sooriya
commented
Oct 1, 2025
| const matchesAccount = Object.values(internalAccounts.accounts).some( | ||
| (account) => { | ||
| const matchesScope = account.scopes?.some((scope) => { | ||
| const matchesScope = account.scopes.some((scope) => { |
There was a problem hiding this comment.
Removing this hotfix from my OG PR (was done to ensure CI was green)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [fae2ef2]
UI Startup Metrics (1238 ± 80 ms)
Benchmark value 253 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 268 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 35 exceeds gate value 33 for chrome browserify home p95 getState Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2403 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1927 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1908 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 23 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 57 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 1903 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2897 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2363 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2349 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 85 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 335 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 334 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 198 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2336 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 201 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1423 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 251 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 6 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 303 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 10 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 1165ms | Sum of p95 exceeds: 2386.8ms Sum of all benchmark exceeds: 3551.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uncovered when running E2E tests. It seems that this 105.ts migration ended up removing/not adding the
scopesproperty on our internal accounts.This ensures we add back the scopes property.
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
https://www.loom.com/share/0ed66cf144c140fc84868d95e3500bb8?sid=20a77514-b5b6-40fe-9e3b-7a245955914d
Pre-merge author checklist
Pre-merge reviewer checklist