Skip to content

Conversation

@bergarces
Copy link
Contributor

@bergarces bergarces commented Oct 8, 2025

Explanation

Change field name so that we can easily use the new selector result without doing a cumbersome mapping, as it currently clashes with a field on an interface that uses the same name.

Preview PRs for extension and mobile.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Renames the token selector result field from type to accountType across selectors and tests, and documents it as a breaking change.

  • Selectors (src/selectors/token-selectors.ts):
    • Rename Asset field typeaccountType and update all constructed asset objects accordingly (EVM and multichain paths).
  • Tests (src/selectors/token-selectors.test.ts):
    • Update expectations to use accountType instead of type.
  • Changelog:
    • Add Unreleased entry marking the rename as BREAKING.

Written by Cursor Bugbot for commit 44207a4. This will update automatically on new commits. Configure here.

@bergarces bergarces requested a review from a team as a code owner October 8, 2025 18:01
@bergarces bergarces requested a review from a team as a code owner October 8, 2025 18:04
@bergarces
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/account-tree-controller": "1.4.0-preview-44207a4",
  "@metamask-previews/accounts-controller": "33.1.0-preview-44207a4",
  "@metamask-previews/address-book-controller": "6.1.1-preview-44207a4",
  "@metamask-previews/announcement-controller": "7.0.3-preview-44207a4",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-44207a4",
  "@metamask-previews/approval-controller": "7.1.3-preview-44207a4",
  "@metamask-previews/assets-controllers": "78.0.1-preview-44207a4",
  "@metamask-previews/base-controller": "8.4.0-preview-44207a4",
  "@metamask-previews/bridge-controller": "48.0.0-preview-44207a4",
  "@metamask-previews/bridge-status-controller": "48.0.0-preview-44207a4",
  "@metamask-previews/build-utils": "3.0.3-preview-44207a4",
  "@metamask-previews/chain-agnostic-permission": "1.1.1-preview-44207a4",
  "@metamask-previews/composable-controller": "11.0.0-preview-44207a4",
  "@metamask-previews/controller-utils": "11.14.0-preview-44207a4",
  "@metamask-previews/core-backend": "1.0.0-preview-44207a4",
  "@metamask-previews/delegation-controller": "0.7.0-preview-44207a4",
  "@metamask-previews/earn-controller": "8.0.0-preview-44207a4",
  "@metamask-previews/eip-5792-middleware": "1.2.0-preview-44207a4",
  "@metamask-previews/eip1193-permission-middleware": "1.0.0-preview-44207a4",
  "@metamask-previews/ens-controller": "17.0.1-preview-44207a4",
  "@metamask-previews/error-reporting-service": "2.2.0-preview-44207a4",
  "@metamask-previews/eth-json-rpc-provider": "5.0.0-preview-44207a4",
  "@metamask-previews/foundryup": "1.0.1-preview-44207a4",
  "@metamask-previews/gas-fee-controller": "24.0.0-preview-44207a4",
  "@metamask-previews/gator-permissions-controller": "0.2.0-preview-44207a4",
  "@metamask-previews/json-rpc-engine": "10.1.0-preview-44207a4",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-44207a4",
  "@metamask-previews/keyring-controller": "23.1.0-preview-44207a4",
  "@metamask-previews/logging-controller": "6.0.4-preview-44207a4",
  "@metamask-previews/message-manager": "13.0.0-preview-44207a4",
  "@metamask-previews/messenger": "0.3.0-preview-44207a4",
  "@metamask-previews/multichain-account-service": "1.6.0-preview-44207a4",
  "@metamask-previews/multichain-api-middleware": "1.2.0-preview-44207a4",
  "@metamask-previews/multichain-network-controller": "1.0.0-preview-44207a4",
  "@metamask-previews/multichain-transactions-controller": "5.0.0-preview-44207a4",
  "@metamask-previews/name-controller": "8.0.3-preview-44207a4",
  "@metamask-previews/network-controller": "24.2.0-preview-44207a4",
  "@metamask-previews/network-enablement-controller": "2.1.0-preview-44207a4",
  "@metamask-previews/notification-services-controller": "18.2.0-preview-44207a4",
  "@metamask-previews/permission-controller": "11.0.6-preview-44207a4",
  "@metamask-previews/permission-log-controller": "4.0.0-preview-44207a4",
  "@metamask-previews/phishing-controller": "14.1.0-preview-44207a4",
  "@metamask-previews/polling-controller": "14.0.0-preview-44207a4",
  "@metamask-previews/preferences-controller": "20.0.1-preview-44207a4",
  "@metamask-previews/profile-sync-controller": "25.1.0-preview-44207a4",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-44207a4",
  "@metamask-previews/remote-feature-flag-controller": "1.7.0-preview-44207a4",
  "@metamask-previews/sample-controllers": "2.0.0-preview-44207a4",
  "@metamask-previews/seedless-onboarding-controller": "4.0.0-preview-44207a4",
  "@metamask-previews/selected-network-controller": "24.0.0-preview-44207a4",
  "@metamask-previews/shield-controller": "0.3.0-preview-44207a4",
  "@metamask-previews/signature-controller": "34.0.0-preview-44207a4",
  "@metamask-previews/subscription-controller": "1.0.0-preview-44207a4",
  "@metamask-previews/token-search-discovery-controller": "3.3.0-preview-44207a4",
  "@metamask-previews/transaction-controller": "60.6.0-preview-44207a4",
  "@metamask-previews/user-operation-controller": "39.0.0-preview-44207a4"
}

@bergarces bergarces merged commit 7878d3a into main Oct 9, 2025
244 checks passed
@bergarces bergarces deleted the change-account-type-field-name branch October 9, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants