Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix in the monster table #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

memmaker
Copy link

@memmaker memmaker commented Mar 9, 2024

IsGreed is supposed to be the flag

IsGreed is supposed to be the flag
@MestreLion
Copy link
Owner

Wow, nicely spotted, thanks!

This being a gameplay change, even a bugfix one, would you mind enclosing it in a #ifdef ROGUE_BUGFIX block, keeping the original behavior in the #else clause?

This means ISGREED, being currently (well, in 1985) at m_carry, gives the Leprechaun a huge chance of carrying items. It seems UNIX Rogue 5.x, which supposedly this Epyx Rogue was based on, had both m_carry and m_flag set to 0! Maybe de-compiling v1.49 would also help.

In any case, simply swapping the values might not be the "proper" fix. Would have to check other versions from the same era to discover the what the intended values were supposed to be.

@MestreLion MestreLion added the gameplay Affects original gameplay label Mar 13, 2024
@MestreLion
Copy link
Owner

On a side-note to myself, I'll have to add this new ROGUE_BUGFIX to documentation, and retroactively apply it to #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gameplay Affects original gameplay
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants