Fix P2002 race in concurrent origin registration#927
Merged
Conversation
…tration When multiple resources from the same origin register concurrently, each transaction's resourceOrigin.upsert() can race — two see no row, both try INSERT, second gets a unique constraint violation. Pre-creating origin rows outside transactions uses native INSERT ON CONFLICT, which is safe from this race.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P2002) onresourceOrigin.upsert()when multiple resources from the same origin (e.g.stableschedule.dev) register concurrentlyINSERT ON CONFLICT, which is safe from the race that interactive transactions hit (SELECT → INSERT race)Context
Reported via Discord: registering
stableschedule.dev(8 resources, 1 origin) fails on 2 resources withInvalid prisma.resourceOrigin.upsert() invocation: Unique constraint failed on the fields: ('origin'). The same origin works fine on mppscan.