Skip to content

Conversation

@tanevanwifferen
Copy link
Contributor

  • Introduced SelectSetting components for mic activation mode and location updates mode in PrivacySettingsScreen.
  • Added new settings keys for mic activation mode and location updates mode in settings store.
  • Implemented logic in MantleManager to handle location updates based on the selected mode.
  • Enhanced location handling to prefer cached good fixes and manage location updates more efficiently.
  • Updated i18n translations for new settings.
  • Adjusted MantleBridge to handle head position changes and trigger location updates accordingly.
  • Improved app status refresh logic with exponential backoff and foreground state notifications.
  • Updated Reactotron configuration to connect only in development mode.

I've only been able to test with G1's, so please test thoroughly

- Introduced SelectSetting components for mic activation mode and location updates mode in PrivacySettingsScreen.
- Added new settings keys for mic activation mode and location updates mode in settings store.
- Implemented logic in MantleManager to handle location updates based on the selected mode.
- Enhanced location handling to prefer cached good fixes and manage location updates more efficiently.
- Updated i18n translations for new settings.
- Adjusted MantleBridge to handle head position changes and trigger location updates accordingly.
- Improved app status refresh logic with exponential backoff and foreground state notifications.
- Updated Reactotron configuration to connect only in development mode.
@tanevanwifferen tanevanwifferen requested a review from a team as a code owner October 18, 2025 23:12
@fossephate
Copy link
Contributor

Hey, appreciate the PR and I think there are some good changes in here
but unfortunately we're working on a very large refactor at the moment (see the android-3 branch) and this won't make much sense to merge
I'll go over the changes you've made though with the team on our next sync and see if we can bring some of these features in a future release
If you're keen on contributing I can't recommend basing your changes off of the android-3 branch just yet since it's still unstable but once it gets merged feel free to rebase off of dev

@tanevanwifferen
Copy link
Contributor Author

Ah ok, good to know @fossephate

There's this battery issue on iphone which I've tried to address with this PR, so it would be great if you address this

Issues I see

  • mic 100% of the time is on
  • the websocket seems to be polling every 5 seconds

The mic issue can be solved simply, the networking issue seems like a bigger deal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants