fix: sanitize topic parameter in tool_diary_write#936
Open
shaun0927 wants to merge 1 commit intoMemPalace:developfrom
Open
fix: sanitize topic parameter in tool_diary_write#936shaun0927 wants to merge 1 commit intoMemPalace:developfrom
shaun0927 wants to merge 1 commit intoMemPalace:developfrom
Conversation
agent_name and entry are validated via sanitize_name/sanitize_content, but topic is stored raw into ChromaDB metadata. Apply the same sanitize_name guard to reject null bytes, path traversal, and oversized payloads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
tool_diary_writevalidatesagent_nameviasanitize_name()(line 926) andentryviasanitize_content()(line 927), but storestopicraw into ChromaDB metadata at line 967. Any string — including null bytes, path traversal sequences, or megabyte-length payloads — passes through unchecked.This is consistent with the input validation pattern already applied to every other MCP tool parameter (e.g.
wing,room,agent_nameintool_add_drawer;subject/predicate/objectintool_kg_addviasanitize_kg_value).Refs: #934 (Finding 4)
How to test
Checklist
ruff check mempalace/mcp_server.py— passedruff format --check mempalace/mcp_server.py— passed