Keep HTML reporter registered when MTA is unavailable#5
Conversation
On external clusters without a local MTA (e.g. Pre-Tyche), MTT::Mail::Init fails and the HTML reporter returned 0 at Init, so it was never registered and Submit/Finalize never wrote any HTML reports. Disable email delivery (set $to=undef) but return 1 so HTML reports are still generated on disk. Reported-by: Bartlomiej Pawulski <bpawulski@nvidia.com>
📝 WalkthroughWalkthroughIn ChangesHTML Reporter Mail-Failure Fallback
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Validated on Pre-Tyche (SLURM job 2273616, ucx-enroot suite, aarch64 container). With this fix, the HTML reporter stays registered despite no MTA and writes reports to disk via
The prior unpatched run (job 2273422) produced zero HTML files under the same configuration, confirming this is the fix. |
Summary
On external clusters without a local MTA (e.g. Pre-Tyche),
MTT::Mail::Initfails and the HTML reporter previously returned 0 at Init, so it was never registered andSubmit/Finalizenever wrote any HTML reports. This disables email delivery (sets$to=undef) but returns 1 so HTML reports are still generated on disk.Email-sending in
Submitis already guarded byif ($to), so clearing$tocleanly skips email while HTML table generation continues.Test plan
All_phase-summary.htmland per-suite HTML on disk without an MTAReported-by: Bartlomiej Pawulski bpawulski@nvidia.com