Skip to content

Conversation

@spth
Copy link

@spth spth commented Oct 14, 2020

This is just a very minor issue.

megaglest contains some calls to strerror where the result is assigned to a char *. However, according to the strerror specification, the string returned by strerror should never be changed, so I think it would be better to use const char * instead.

Philipp

Copy link
Contributor

@Jammyjamjamman Jammyjamjamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks ok to merge.

@AndyMender
Copy link

I think it's a good idea to use const and constexpr wherever possible, both as a nod to other developers and a safety net for vars which shouldn't change :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants