Skip to content

Commit

Permalink
Merge pull request #155 from MediaMarktSaturn/fix-mount-defaultmode
Browse files Browse the repository at this point in the history
[Application] Fix secret and configmap volume mount defaultMode
  • Loading branch information
heubeck authored Oct 29, 2024
2 parents 36567c4 + 98ac7c5 commit 45a6748
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion charts/application/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ maintainers:
- name: MediaMarktSaturn
url: https://github.com/MediaMarktSaturn
appVersion: 1.0.0
version: 1.26.0
version: 1.26.1
12 changes: 6 additions & 6 deletions charts/application/templates/_podTemplate.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -303,17 +303,11 @@ spec:
{{- range .Values.secretVolumes }}
- name: {{ .secretName }}
mountPath: {{ .mountPath }}
{{- if .defaultMode }}
defaultMode: {{ .defaultMode }}
{{- end }}
readOnly: true
{{- end }}
{{- range .Values.configVolumes }}
- name: {{ .configMapName }}
mountPath: {{ .mountPath }}
{{- if .defaultMode }}
defaultMode: {{ .defaultMode }}
{{- end }}
readOnly: true
{{- end }}
{{- if .Values.serviceAccount.secretName }}
Expand Down Expand Up @@ -350,11 +344,17 @@ spec:
- name: {{ .secretName }}
secret:
secretName: {{ .secretName }}
{{- if .defaultMode }}
defaultMode: {{ .defaultMode }}
{{- end }}
{{- end }}
{{- range .Values.configVolumes }}
- name: {{ .configMapName }}
configMap:
name: {{ .configMapName }}
{{- if .defaultMode }}
defaultMode: {{ .defaultMode }}
{{- end }}
{{- end }}
{{- if .Values.serviceAccount.secretName }}
- name: service-account
Expand Down
4 changes: 2 additions & 2 deletions charts/application/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -128,13 +128,13 @@ disruptionBudget:
secretVolumes: []
# - secretName: mysecret
# mountPath: /mypath
# defaultMode: 420
# defaultMode: 0420

# list of configmaps to be mounted to app pod
configVolumes: []
# - configMapName: myconfigmap
# mountPath: /mypath
# defaultMode: 420
# defaultMode: 0420

# list of secret names to be used as envFrom entries
secretEnvFrom: []
Expand Down

0 comments on commit 45a6748

Please sign in to comment.