Incorporate review suggestions by @heubeck

MediaMarktSaturn · Mar 22, 2023 · 3fe06b2 · 3fe06b2
1 parent e3f32fb
commit 3fe06b2
Show file tree

Hide file tree

Showing 9 changed files with 4 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -33,6 +33,8 @@ The [OWASP Dependency-Track](https://owasp.org/www-project-dependency-track/) pr
 
 A CronJob that deletes terminated/failed pods from a Kubernetes cluster.
 
+Useful when e.g. provisioning Google Kubernetes Engine clusters with preemptible nodes. The preemption leads to pods being shut down during node recreation, however the pods are still kept and displayed when listing them.
+
 ---
 
 _This repository is published under the [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0)_

diff --git a/...tests/k8s-pod-cleanup/ci/test-values.yaml → chart-tests/pod-cleanup/ci/test-values.yaml b/...tests/k8s-pod-cleanup/ci/test-values.yaml → chart-tests/pod-cleanup/ci/test-values.yaml
diff --git a/charts/k8s-pod-cleanup/Chart.yaml → charts/pod-cleanup/Chart.yaml b/charts/k8s-pod-cleanup/Chart.yaml → charts/pod-cleanup/Chart.yaml
@@ -1,5 +1,5 @@
 apiVersion: v2
-name: k8s-pod-cleanup
+name: pod-cleanup
 home: https://github.com/MediaMarktSaturn/helm-charts
 description: Helm Chart for cleaning up failed/terminated Kubernetes pods
 type: application

diff --git a/charts/k8s-pod-cleanup/README.md → charts/pod-cleanup/README.md b/charts/k8s-pod-cleanup/README.md → charts/pod-cleanup/README.md
@@ -1,4 +1,4 @@
-# k8s-pod-cleanup
+# pod-cleanup
 
 ![Version: 1.0.0](https://img.shields.io/badge/Version-1.0.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
 

diff --git a/...8s-pod-cleanup/templates/clusterrole.yaml → ...ts/pod-cleanup/templates/clusterrole.yaml b/...8s-pod-cleanup/templates/clusterrole.yaml → ...ts/pod-cleanup/templates/clusterrole.yaml
diff --git a/...cleanup/templates/clusterrolebinding.yaml → ...cleanup/templates/clusterrolebinding.yaml b/...cleanup/templates/clusterrolebinding.yaml → ...cleanup/templates/clusterrolebinding.yaml
diff --git a/...ts/k8s-pod-cleanup/templates/cronjob.yaml → charts/pod-cleanup/templates/cronjob.yaml b/...ts/k8s-pod-cleanup/templates/cronjob.yaml → charts/pod-cleanup/templates/cronjob.yaml
diff --git a/...pod-cleanup/templates/serviceaccount.yaml → ...pod-cleanup/templates/serviceaccount.yaml b/...pod-cleanup/templates/serviceaccount.yaml → ...pod-cleanup/templates/serviceaccount.yaml
diff --git a/charts/k8s-pod-cleanup/values.yaml → charts/pod-cleanup/values.yaml b/charts/k8s-pod-cleanup/values.yaml → charts/pod-cleanup/values.yaml
-Original file line number
+Diff line change
@@ Expand Up @@
     A CronJob that deletes terminated/failed pods from a Kubernetes cluster.
+    Useful when e.g. provisioning Google Kubernetes Engine clusters with preemptible nodes. The preemption leads to pods being shut down during node recreation, however the pods are still kept and displayed when listing them.
     ---
     _This repository is published under the [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0)_
@@ Expand Down @@