Add border to non federated notifications for admins and moderators #1432
Conversation
Add border to non federated notifications for admins and moderators This allows admins/moderators (when they receive notifications in the future) to quickly see if there has been any activity by local users on their instance
…r-admins-and-moderators
Title shows entry as local and author
…r-admins-and-moderators
…r-admins-and-moderators
remove bordering from here
Saves a lot of var checking and gives more potential for future visual improvements in the notifications
…r-admins-and-moderators
…r-admins-and-moderators
…r-admins-and-moderators
|
What are those random |
| {{ component('user_inline', {user: notification.comment.user}) }} {{ 'replied_to_your_comment'|trans|lower }} - <a | ||
| href="{{ entry_comment_view_url(notification.comment) }}#{{ get_url_fragment(notification.comment) }}">{{ notification.comment.shortTitle }}</a> | ||
| {% endblock entry_comment_reply_notification %} | ||
|
|
||
| {% block entry_comment_deleted_notification %} | ||
| ><div> |
There was a problem hiding this comment.
I honestly thing that this is just bad practice... It might do the job but it is not easy to maintain or to read...
There was a problem hiding this comment.
I agree, though I don't see another way of achieving it without reorganizing the entire notifications code
There was a problem hiding this comment.
You can set the class in an if in the front.html.twig inside of the notifications folder. As far as I can tell you just want to do it for specific notification types right? You have the notification.type variable there to check that
There was a problem hiding this comment.
So creating a new class for every kind of notification, I guess that would work. The benefit of having the logic in the blocks is that in the future we can do more than just a coloured border, like adding a symbol for different situations, I'm not sure what idea I had on that about though, I think indicating when something is done by a local user, not just locally.
|
This PR is stale because it has been open 40 days with no activity. |
Added new_signup block