Policy tests with the wrong variant for ECDSA or PSS #10301
+47
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
needs-review
github-project-automation
bot
moved this to In Development
in Non-roadmap pull requests
ECDSA has two variants (deterministic vs randomized) with the same verification algorithm, and signature algorithms that are functionally indistinguishable but have different security properties. RSA-PSS has two variants in the PSA API (`PSA_ALG_RSA_PSS` vs `PSA_ALG_RSA_PSS_ANY_SALT`) which have the same signature algorithm, but functionally different verification: the any-salt variant accepts some signatures that the default variant rejects (the default variant insists on a specific salt length). Add test cases that validate that a key can't be used with the wrong variant. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
force-pushed
the
psa-ecdsa-verify-other-variant-test-3.6
branch
from
751016a to
bbe288f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some PSA policy test cases with the wrong variant for ECDSA (deterministic vs randomized) and for RSASSA-PSS (
PSA_ALG_RSA_PSSvsPSA_ALG_RSA_PSS_ANY_SALT).(This came up in a PSA Crypto working group discussion — currently the PSA API requires ECDSA verification to obey the policy strictly, but says that for ML-DSA the two variants should be treated as interchangeable for verification.)
PR checklist