Skip to content

Remove support for static ECDH cipher suites #10294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

bjwtaylor
Copy link

@bjwtaylor bjwtaylor commented Jul 10, 2025

Description

Remove support for static ECDH cipher suites, depends Mbed-TLS/TF-PSA-Crypto#377
resolves #9201

This PR is part of a chain which needs to be merged in the following order:

  1. Remove support for static ECDH cipher suites mbedtls-framework#182
  2. Remove support for static ECDH cipher suites #10294

PR checklist

@bjwtaylor bjwtaylor added the needs-ci Needs to pass CI tests label Jul 10, 2025
@bjwtaylor bjwtaylor force-pushed the remove-static-ecdh branch from 375cc45 to 87b15cf Compare July 10, 2025 13:42
@bjwtaylor bjwtaylor added needs-review Every commit must be reviewed by at least two team members, needs-preceding-pr Requires another PR to be merged first needs-reviewer This PR needs someone to pick it up for review and removed needs-ci Needs to pass CI tests labels Jul 11, 2025
@bjwtaylor bjwtaylor marked this pull request as ready for review July 11, 2025 07:25
@valeriosetti valeriosetti self-requested a review July 15, 2025 11:13
Comment on lines 395 to 396
#define MBEDTLS_KEY_EXCHANGE_ECDH_ECDSA_ENABLED
#define MBEDTLS_KEY_EXCHANGE_ECDH_RSA_ENABLED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not change this document. For example some time ago I removed support for MBEDTLS_KEY_EXCHANGE_DHE_PSK_ENABLED, but this is still documented in this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. At this point config-split.md is mostly a historical record that we shouldn't touch unless it's to clarify what already happened. (Also we should move it out of proposed/ but that's out of scope here.)

@gilles-peskine-arm gilles-peskine-arm added needs-work size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon and removed needs-review Every commit must be reviewed by at least two team members, needs-preceding-pr Requires another PR to be merged first needs-reviewer This PR needs someone to pick it up for review labels Jul 15, 2025
@gilles-peskine-arm
Copy link
Contributor

Mbed-TLS/mbedtls-framework#182 is now merged.

@bjwtaylor bjwtaylor force-pushed the remove-static-ecdh branch from 62aa327 to 521bd12 Compare July 17, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-work priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
Development

Successfully merging this pull request may close these issues.

Remove static ECDH cipher suites
3 participants