Add code style check #93
Conversation
tom-daubney-arm
added
enhancement
|
@ronald-cron-arm I have just realised that I have not yet got the all.sh component in place. I will do that this afternoon so I will remove the |
tom-daubney-arm
added
needs-work
and removed
needs-review
tom-daubney-arm
added
needs-review
Now done and ready for review. |
.uncrustify.cfg
Outdated
| @@ -0,0 +1,240 @@ | |||
| # Configuration options for Uncrustify specifying the Mbed TLS code style. | |||
There was a problem hiding this comment.
I'd prefer to copy that file from Mbed TLS instead of committing it into the development branch.
There was a problem hiding this comment.
Ok, can change that.
There was a problem hiding this comment.
I will need to add a new function to the psa_crypto.py script to allow for copying files from the root directory in order to achieve this since currently only things from sub-directories are copied.
There was a problem hiding this comment.
yes sure you can add one
|
|
||
| component_check_code_style () { | ||
| msg "Check C code style" | ||
| ./scripts/code_style.py |
There was a problem hiding this comment.
I've tried to run it and it seems we miss check-generated-files.sh.
There was a problem hiding this comment.
Hmm, ok not sure why. Will investigate.
There was a problem hiding this comment.
As discussed, I misunderstood the meaning of the initial comment. I have added check-generated-files.sh to be copied in psa_crypto.py.
Signed-off-by: Thomas Daubney <[email protected]>
Signed-off-by: Thomas Daubney <[email protected]>
Signed-off-by: Thomas Daubney <[email protected]>
Signed-off-by: Thomas Daubney <[email protected]>
Commit removes the existing uncrustify config file and adds it for copying in psa_crypto.py. This required the creation of a new function in psa_crypto.py called copy_from_root. Signed-off-by: Thomas Daubney <[email protected]>
tom-daubney-arm
force-pushed
the
add_code_style_check
branch
from
9da43fa to
ce66409
Compare
|
@ronald-cron-arm @gabor-mezei-arm merge conflict is resolved so this is ready for review. |
tom-daubney-arm
removed
the
needs-reviewer
Fixes #48
PR relies on changes to the following files which are brought in on Mbed TLS PR #8523 which is now merged:
scripts/generate_driver_wrappers.pyscripts/mbedtls_dev/build_tree.pytests/scripts/check-generated-files.sh