Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doxygen components #142

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

Harry-Ramsey
Copy link
Contributor

@Harry-Ramsey Harry-Ramsey commented Jan 8, 2025

Description

This commit enables doxygen components (specifically checks and warnings) for TF-PSA-Crypto. Closes #49.

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

  • changelog not required because: testing enhancement.
  • framework PR provided Mbed-TLS/mbedtls-framework: #115
  • mbedtls PR not required.
  • tests provided.

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@Harry-Ramsey Harry-Ramsey force-pushed the enable-doxygen branch 3 times, most recently from cbfa3c0 to 59d1154 Compare January 9, 2025 09:43
@Harry-Ramsey Harry-Ramsey changed the title Enable Doxygen Checks Add doxygen components Jan 9, 2025
@Harry-Ramsey Harry-Ramsey self-assigned this Jan 10, 2025
@Harry-Ramsey Harry-Ramsey force-pushed the enable-doxygen branch 2 times, most recently from 4096adc to eafc659 Compare January 10, 2025 14:39
@Harry-Ramsey Harry-Ramsey force-pushed the enable-doxygen branch 2 times, most recently from bf1a9c5 to 177efd5 Compare January 23, 2025 17:22
@ronald-cron-arm ronald-cron-arm self-requested a review February 3, 2025 10:08
This commit adds the components check_doxy_blocks and
check_doxygen_warnings to TF-PSA-Crypto.

Signed-off-by: Harry Ramsey <[email protected]>
@Harry-Ramsey Harry-Ramsey force-pushed the enable-doxygen branch 5 times, most recently from e93d1db to 2eb5924 Compare February 6, 2025 13:32
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In doxygen/tfpsacrypto.doxyfile.in we need to change the entries INPUT, EXCLUDE and INCLUDE_PATH, aligning them with what we currently have in doxygen/mbedtls.doxyfile in Mbed TLS (we cannot ignore the legacy headers yet):

INPUT                  = ../include input ../drivers/builtin/include
EXCLUDE             = ../include/psa/crypto_se_driver.h ../drivers/builtin/include/mbedtls/build_info.h
INCLUDE_PATH  = ../include ../drivers/builtin/include

@@ -133,6 +133,15 @@ def full_adapter(name, value, active):
return active
return include_in_full(name)

def realfull_adapter(_name, _value, _active):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add something in custom_parser_options in class TFPSACryptoConfigTool as well I think.

This commit adds a new adapter, realfull which is ued to activate all
symbols. This is required for the doxygen test suite.

Signed-off-by: Harry Ramsey <[email protected]>
This commit updates the doxyfile to contain the relevant paths for the
doxygen generation.

Signed-off-by: Harry Ramsey <[email protected]>
@ronald-cron-arm
Copy link
Contributor

I've updated the framework pointer that was not correct to get a new run of CI.

This commit updates the framework to enable doxygen checks.

Signed-off-by: Harry Ramsey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: TF-PSA-Crypto all.sh 1 - basic-checks
Development

Successfully merging this pull request may close these issues.

Add doxygen checks
2 participants