-
Notifications
You must be signed in to change notification settings - Fork 23
Gracefully Handle HTCondor Collector Updates #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Gracefully Handle HTCondor Collector Updates #378
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #378 +/- ##
==========================================
+ Coverage 98.94% 99.05% +0.11%
==========================================
Files 55 55
Lines 2266 2338 +72
==========================================
+ Hits 2242 2316 +74
+ Misses 24 22 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
30aba51 to
f556898
Compare
f556898 to
f276b73
Compare
|
For the time being, the new mocked executor utility is called mock_executor_run_command_new. I will open a new issue to refactor other adapters that currently use mock_executor_run_command. Once that is done, mock_executor_run_command_new will replace the old mock_executor_run_command as the standard utility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really part of the feature, but fixing Type Hints is always good when visting the code anyhow.
77795dd to
887f152
Compare
887f152 to
f0d3906
Compare
|
Stil in draft mode, but reviewers are already invited to comment about the implementation. :-) |
3c442f5 to
ac9cac3
Compare
ac9cac3 to
3b27beb
Compare
tardis/utilities/asynccachemap.py
Outdated
| and self._update_coroutine_receives_cache | ||
| == other._update_coroutine_receives_cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is extremely specific now. I guess you can just check for identity as return self is other (which then also doesn't need the type check).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed that as well. Thanks for spotting this.
2ed78bb to
10b7169
Compare
maxfischer2781
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I've got a general maintenance comment, but it doesn't have to be forced into this PR.
Co-authored-by: Max Kühn <[email protected]>
maxfischer2781
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realised I let this sit for a while. Thanks for the updates, LGTM.
DaemonStartTimeof HTCondorMasterdaemonDaemonStartTimewhen updating machine statusexecutor.run_commandcallsFixes #376