Add support for openstack application credentials #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 98.88% // Head: 98.88% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #274 +/- ##
=======================================
Coverage 98.88% 98.88%
=======================================
Files 56 56
Lines 2325 2325
=======================================
Hits 2299 2299
Misses 26 26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
giffels
force-pushed
the
add-openstack-app-creds
branch
from
d56946a to
a203b86
Compare
giffels
requested review from
a team,
eileen-kuehn and
rfvc
and removed request for
a team
giffels
force-pushed
the
add-openstack-app-creds
branch
from
b40c7ac to
8dc97c3
Compare
eileen-kuehn
approved these changes
Jan 13, 2023
Member
eileen-kuehn
left a comment
eileen-kuehn
left a comment
There was a problem hiding this comment.
Back in the game 🥳 go for it! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables support for OpenStack application credentials . The OpenStack now supports the traditional authentication using
usernameandpasswordas well asapplication_credential_idandapplication_credential_secret.This change was actual part of #231. So, in case miss a corresponding unittest, it will be part of #231 since it relies on the migration to Pydantic for input validation.