Skip to content

SF8 deprecations solving #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Griffon-Weglot wants to merge 2 commits into from
Closed

SF8 deprecations solving #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa9d55a
SF8 deprecations solving
Griffon-Weglot Dec 10, 2025
6c2d6a7
phpstan
Griffon-Weglot Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/EmailChecker/Constraints/NotThrowawayEmail.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,20 @@ class NotThrowawayEmail extends Constraint
*/
public $message = 'The domain associated with this email is not valid.';

/**
* @param array<string, mixed>|string|null $message
*/
public function __construct(
$options = null,
array|string|null $message = null,
?array $groups = null,
$payload = null,
?string $message = null,
mixed $payload = null,
) {
$options = [];
if (\is_array($message)) {
$options = $message;
$message = $options['message'] ?? null;
}

parent::__construct($options, $groups, $payload);

$this->message = $message ?? $this->message;
Expand Down
6 changes: 1 addition & 5 deletions src/EmailChecker/Constraints/NotThrowawayEmailValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
namespace EmailChecker\Constraints;

use EmailChecker\EmailChecker;
use ReturnTypeWillChange;
use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\ConstraintValidator;
use Symfony\Component\Validator\Exception\UnexpectedTypeException;
Expand All @@ -34,11 +33,8 @@ public function __construct(?EmailChecker $emailChecker = null)

/**
* @param mixed $value
*
* @return void
*/
#[ReturnTypeWillChange]
public function validate($value, Constraint $constraint)
public function validate($value, Constraint $constraint): void
{
if (!$constraint instanceof NotThrowawayEmail) {
throw new UnexpectedTypeException($constraint, NotThrowawayEmail::class);
Expand Down