Fix binary availabilities #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattFenelon
requested changes
Sep 4, 2020
bin/compile
Outdated
| topic "Configure application environment" | ||
| mkdir -p $BUILD_DIR/.profile.d | ||
| exports "\$HOME/vendor/poppler" > $BUILD_DIR/.profile.d/000_poppler.sh | ||
| echo "export PATH=/app/vendor/poppler/bin:$PATH" >> $BUILD_DIR/.profile.d/000_poppler.sh |
Owner
There was a problem hiding this comment.
I believe you should be able to add this to the exports function, near the top of the file.
Contributor
Author
There was a problem hiding this comment.
solved by my last commit. Thanks!
Owner
|
Thanks @did. Can you look at my comments and update from |
Owner
|
No problem @did. Would you mind trying it with the change I just made? I can't debug from here. |
Contributor
Author
Sure, I'll do that on Monday if you don't mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @MattFenelon, sorry about this last commit. It turned out that it was the last missing piece of puzzle to make my app work with poppler. thanks!