Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate centralized CI from MatrixAI/.github repo #8

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

CMCDragonkai
Copy link
Member

@CMCDragonkai CMCDragonkai commented Dec 20, 2024

Description

Change to using the centralized workflows from MatrixAI/.github#3.

Issues Fixed

Tasks

  • 1. Created feature.yml
  • 2. Created staging.yml
  • 3. Created tag.yml
  • 4. Simpolified lint.mjs script so it lints everything - code, shell scripts, markdown

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@CMCDragonkai
Copy link
Member Author

The 3 check jobs have worked in def8a5e. You can see that we do need to always make use of the github runner for this to work cause we should always be inside a nix develop shell to do this.

@CMCDragonkai
Copy link
Member Author

I'm going to need to test the staging and tag CI now... this may involve several commits on staging branch to see how this works.

@CMCDragonkai
Copy link
Member Author

Right now we have the relevant CI here setup. And so, upon merge, we should see that a job runs for the staging commit as usual.

Afterwards, I need to do a tag release and see if that works.

If that works, we can attempt some optimisation.

  1. Staging branch jobs would run along the tag jobs. They are independent workflows. However this creates a bit of duplication. The job running for the version commit could be skipped. This requires something that skips the jobs for the staging workflow if the tag workflow is expected to run. However only the caller workflow knows this, so it could run a job that first checks the commit message and output a match output that is checked by the use-library-js-staging workflow and let the tag workflow work that out.
  2. It's also possible to skip jobs for commits that the feature branch has already done, and thus merged. However this is a lesser concern.

@CMCDragonkai CMCDragonkai force-pushed the feature-ci branch 2 times, most recently from afd4683 to 5939c47 Compare December 21, 2024 22:21
@CMCDragonkai
Copy link
Member Author

Alright merging to test staging.

@CMCDragonkai
Copy link
Member Author

We still have to switch back to @master when it is all done.

@CMCDragonkai CMCDragonkai merged commit 1f9c6b3 into staging Dec 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant