Skip to content

Conversation

@def-
Copy link
Contributor

@def- def- commented Nov 19, 2025

Shouldn't be set, as noted by @alex-hunt-materialize
Test run: https://buildkite.com/materialize/nightly/builds/14124

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch 3 times, most recently from 8304776 to b696e2d Compare November 20, 2025 11:37
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch from b696e2d to b42d451 Compare November 20, 2025 13:34
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch from b42d451 to de0b470 Compare November 20, 2025 18:24
@def- def- requested a review from a team as a code owner November 20, 2025 18:24
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch 2 times, most recently from 37aff13 to 65bc9f3 Compare November 20, 2025 20:13
@def- def- changed the title orchestratord test: rolling upgrade orchestratord test: rolling upgrade + introduce mz-debug Nov 21, 2025
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch from 65bc9f3 to 893dfa9 Compare November 21, 2025 16:37
@def- def- requested a review from doy-materialize November 21, 2025 16:41
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch 2 times, most recently from 4c291fb to eddf132 Compare November 21, 2025 22:26
@def- def- marked this pull request as draft November 21, 2025 22:26
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch 10 times, most recently from 373da48 to 11a9d24 Compare November 25, 2025 07:45
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch from 11a9d24 to 233cfba Compare November 25, 2025 07:58
continue
if (
not status["conditions"]
or status["conditions"][0]["type"] != "UpToDate"
Copy link
Contributor

@alex-hunt-materialize alex-hunt-materialize Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
or status["conditions"][0]["type"] != "UpToDate"
or status["conditions"][0]["type"] != "UpToDate"
or status["conditions"][0]["status"] != "True"

The UpToDate condition can have one of three statuses:

  • "True"
  • "False"
  • "Unknown"

Typically, when we make changes to the materialize CR, but don't request a rollout, it changes to "False". When we request a rollout, it changes to "Unknown". When it completes the rollout and nothing has changed in the configuration, it changes to "True".

We still need to check the lastCompletedRolloutRequest in the "True" case, to ensure that the "True" value isn't there from a previous rollout and orchestratord has reconciled the Materialize CR since the last change.

@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch 6 times, most recently from 4efe158 to 65f0f20 Compare November 25, 2025 17:03
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch 2 times, most recently from a873fe2 to c5491d1 Compare November 25, 2025 22:43
@def- def- force-pushed the pr-orchestratord-rolling-upgrade branch from c5491d1 to b041890 Compare November 25, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants