-
Notifications
You must be signed in to change notification settings - Fork 483
orchestratord test: rolling upgrade + introduce mz-debug #34214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8304776 to
b696e2d
Compare
b696e2d to
b42d451
Compare
b42d451 to
de0b470
Compare
37aff13 to
65bc9f3
Compare
65bc9f3 to
893dfa9
Compare
4c291fb to
eddf132
Compare
373da48 to
11a9d24
Compare
11a9d24 to
233cfba
Compare
| continue | ||
| if ( | ||
| not status["conditions"] | ||
| or status["conditions"][0]["type"] != "UpToDate" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| or status["conditions"][0]["type"] != "UpToDate" | |
| or status["conditions"][0]["type"] != "UpToDate" | |
| or status["conditions"][0]["status"] != "True" |
The UpToDate condition can have one of three statuses:
"True""False""Unknown"
Typically, when we make changes to the materialize CR, but don't request a rollout, it changes to "False". When we request a rollout, it changes to "Unknown". When it completes the rollout and nothing has changed in the configuration, it changes to "True".
We still need to check the lastCompletedRolloutRequest in the "True" case, to ensure that the "True" value isn't there from a previous rollout and orchestratord has reconciled the Materialize CR since the last change.
4efe158 to
65f0f20
Compare
a873fe2 to
c5491d1
Compare
c5491d1 to
b041890
Compare
Shouldn't be set, as noted by @alex-hunt-materialize
Test run: https://buildkite.com/materialize/nightly/builds/14124
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.