Skip to content

Update launchdarkly-server-sdk to version 2.5.1 #32036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

teskje
Copy link
Contributor

@teskje teskje commented Mar 28, 2025

This updates the launchdarkly-server-sdk dependency to version 2.5.1.

We are still using our own fork mostly because it has MaterializeInc/rust-server-sdk@4d051dd which we can't easily upstream because it doesn't fully solve the issue (see Slack thread). We may be able to depend on upstream again once launchdarkly/rust-server-sdk#116 is resolved. We are able to move back to upstream for the rust-eventsource-client crate at least.

Motivation

  • This PR updates a dependency.

Closes https://github.com/MaterializeInc/database-issues/issues/9113

Tips for reviewer

I rebased our rust-server-sdk fork by pushing to main directly, so there is no PR to review. However, you can view the changes relative to the upstream here. Also the old state of main is still available as the main-backup branch.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@teskje teskje marked this pull request as ready for review March 28, 2025 16:02
@teskje teskje requested review from a team as code owners March 28, 2025 16:02
@teskje teskje requested review from ParkMyCar and antiguru March 28, 2025 16:02
Copy link
Member

@antiguru antiguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test runs lgtm

@teskje
Copy link
Contributor Author

teskje commented Mar 31, 2025

TFTRs!

@teskje teskje enabled auto-merge March 31, 2025 08:11
@teskje teskje merged commit ba8427b into MaterializeInc:main Mar 31, 2025
192 of 254 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants