[persist] Remove some old codec write-path code #32033
Open
+858
−1,146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkirwi
force-pushed
the
rm-codec
branch
6 times, most recently
from
f327eaf to
f031616
Compare
bkirwi
changed the title
bkirwi
force-pushed
the
rm-codec
branch
4 times, most recently
from
1cc6963 to
f633164
Compare
bkirwi
changed the title
ParkMyCar
approved these changes
Apr 1, 2025
| @@ -458,20 +443,13 @@ pub(crate) const INLINE_WRITES_TOTAL_MAX_BYTES: Config<usize> = Config::new( | |||
|
|
|||
| impl BatchBuilderConfig { | |||
| /// Initialize a batch builder config based on a snapshot of the Persist config. | |||
| pub fn new(value: &PersistConfig, shard_id: ShardId) -> Self { | |||
| pub fn new(value: &PersistConfig, _shard_id: ShardId) -> Self { | |||
There was a problem hiding this comment.
Can we just remove the argument if it's unused?
(maybe it's used in a later commit, we'll see!)
There was a problem hiding this comment.
We can, but I don't feel very strongly about it -- I think we've wanted it here ~twice now to do some shard-by-shard rollout? Anyways I'm happy to get this in the next round of changes.
There was a problem hiding this comment.
Since we've needed it so often in the past I'm happy with keeping it!
We'll keep the trait, since it's limited in scope and does some useful type hiding... but now that all parts are structured parts we need much less abstraction.
We know we're always generating structured data here... no need for the enum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Followup to https://github.com/MaterializeInc/database-issues/issues/7411
Part- the structured-only equivalent ofColumnarRecords.Tips for reviewer
This is only partially run through - in particular, I think we can probably do away with
ColumnarRecordsentirely. But it seemed like quite large enough for a first review. (Though possibly not quite as large as it looks... there are a number of mechanical and test changes that inflate the diff size.)I think most changes are separated commit-by-commit, though there's almost certainly been some bleedover. Let me know if this is too much in one go, and I should be able to split it up a bit further.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.