format_char_str: Avoid costly decoding if possible #32018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
format_char_str
function formats a string as a fixed-length string, potentially cutting off overhanging white space. It needs to decode the string to find the position of thelength
character, which is a slow operation.This change introduces an optimization where if a string certainly isn't longer than the length in characters, we bail out early. The reasoning for this is simple: a string of length$n$ can have at most $n$ characters, so the length serves as an upper bound for the number of characters.
Related: MaterializeInc/database-issues#9125
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.