Disable data-ingest KafkaRoundtripExecutor #32016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
requested changes
Mar 26, 2025
test/data-ingest/mzcompose.py
Outdated
| @@ -107,7 +106,9 @@ def workflow_default(c: Composition, parser: WorkflowArgumentParser) -> None: | |||
| "mysql", | |||
| ) | |||
|
|
|||
| executor_classes = [MySqlExecutor, KafkaRoundtripExecutor, KafkaExecutor] | |||
| # KafkaRoundtripExecutor disabled due to intermittent test failure (https://github.com/MaterializeInc/database-issues/issues/8657) | |||
There was a problem hiding this comment.
If you use a format like TODO: Reenable when database-issues#8657 is fixed then I get automatically notified when the issue is closed and the TODO is still in the code
There was a problem hiding this comment.
nice - thanks for the heads up!
def-
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables KafkaRoundtripExecutor as it occasionally fails.
RE: https://github.com/MaterializeInc/database-issues/issues/8657#issuecomment-2719129095
Motivation
CI flake
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.