ci: automate Helm chart packaging and publishing (using Buildkite) #31104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
force-pushed
the
pr-helm-chart-release-workflow
branch
5 times, most recently
from
9265135 to
d9e61fa
Compare
def-
force-pushed
the
pr-helm-chart-release-workflow
branch
6 times, most recently
from
8d928c1 to
a69dccc
Compare
bobbyiliev
reviewed
Jan 20, 2025
There was a problem hiding this comment.
Looks great! Thanks for taking care of this @def-!
Seems like the lint is failing with:
🚨 Failed: xargs shellcheck -P SCRIPTDIR | 0s
-- | --
|
| In misc/helm-charts/publish.sh line 35:
| git clone --branch $GITHUB_PAGES_BRANCH --depth 1 https://[email protected]/MaterializeInc/materialize.git gh-pages
| ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
a69dccc to
bd71965
Compare
|
Fixed |
def-
force-pushed
the
pr-helm-chart-release-workflow
branch
from
bd71965 to
27df072
Compare
bobbyiliev
reviewed
Jan 20, 2025
def-
force-pushed
the
pr-helm-chart-release-workflow
branch
from
27df072 to
0119945
Compare
bobbyiliev
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #31051 (I only converted Bobby's script to run on Buildkite)
Closes #31051
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.