[optimizer] reduce .typ() and .arity() chatter in VOJ #30943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgree
changed the title
jkosh44
pushed a commit
to jkosh44/materialize
that referenced
this pull request
Jan 13, 2025
…#30943) Reduces calls to `MRE::typ()` and `MRE::arity()`. It may be possible to reduce further, but I don't completely understand how `get_left` and `bindings` are being calculated. ### Motivation * This PR refactors existing code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces calls to
MRE::typ()andMRE::arity(). It may be possible to reduce further, but I don't completely understand howget_leftandbindingsare being calculated.Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.