Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: fix the maxrss metrics on macOS #30937

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

teskje
Copy link
Contributor

@teskje teskje commented Jan 3, 2025

On macOS, the ru_maxrss value is for some reason in bytes, not in KiB.

Motivation

  • This PR fixes a previously unreported bug.

On macOS, the value of the mz_metrics_libc_ru_maxrss_bytes metric is off by a factor of 1024.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

On macOS, the ru_maxrss value is for some reason in bytes, not in KiB.
@teskje teskje requested a review from antiguru January 3, 2025 12:42
@teskje teskje marked this pull request as ready for review January 3, 2025 12:42
Copy link
Member

@antiguru antiguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! What a mess!

@teskje
Copy link
Contributor Author

teskje commented Jan 3, 2025

TFTR!

@teskje teskje enabled auto-merge January 3, 2025 13:19
@teskje teskje merged commit fe4d895 into MaterializeInc:main Jan 3, 2025
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants