Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute: minor copy-to sink cleanup #30936

Merged
merged 1 commit into from
Jan 6, 2025
Merged

compute: minor copy-to sink cleanup #30936

merged 1 commit into from
Jan 6, 2025

Conversation

teskje
Copy link
Contributor

@teskje teskje commented Jan 3, 2025 •
edited
Loading

The ResponseProtocol is not shared state anymore, so no reason to wrap it into an Rc<RefCell>.

This simplification became possible thanks to #30844 and #30909.

Motivation

  • This PR refactors existing code.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@teskje
compute: minor copy-to sink cleanup
4c58c70 
The `ResponseProtocol` is not shared state anymore, so no reason to warp
it into an `Rc<RefCell>`.
@teskje teskje marked this pull request as ready for review January 3, 2025 13:20
@teskje teskje requested a review from a team as a code owner January 3, 2025 13:20
@teskje teskje requested a review from benesch January 3, 2025 13:20
benesch
benesch approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@teskje
Copy link
Contributor Author

teskje commented Jan 6, 2025

TFTR!

@teskje teskje merged commit be438cf into MaterializeInc:main Jan 6, 2025
80 checks passed
@teskje teskje deleted the simplify-copy-to-sink branch January 6, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesch benesch benesch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teskje @benesch