Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable many default features #30924

Conversation

alex-hunt-materialize
Copy link
Contributor

@alex-hunt-materialize alex-hunt-materialize commented Dec 31, 2024

Disable many default features, so we don't pull in workspace-hack in the cloud repo when importing orchestratord.

Motivation

  • This PR refactors existing code.
    Don't pull in unneeded dependencies, especially workspace-hack, when importing orchestratord in the cloud repo.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@alex-hunt-materialize alex-hunt-materialize force-pushed the reduce_default_features branch 2 times, most recently from bdd556e to 2f056f3 Compare December 31, 2024 13:20
Disable many default features, so we don't pull in workspace-hack in the
cloud repo when importing orchestratord.
@alex-hunt-materialize alex-hunt-materialize marked this pull request as ready for review December 31, 2024 15:53
@alex-hunt-materialize alex-hunt-materialize marked this pull request as draft December 31, 2024 15:54
@alex-hunt-materialize alex-hunt-materialize marked this pull request as ready for review December 31, 2024 16:41
@alex-hunt-materialize alex-hunt-materialize merged commit bc3a989 into MaterializeInc:main Dec 31, 2024
80 checks passed
@alex-hunt-materialize alex-hunt-materialize deleted the reduce_default_features branch December 31, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants