Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[logging] Don't render large VALUES when redacting #30866

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

mgree
Copy link
Contributor

@mgree mgree commented Dec 18, 2024

We attach SQL statements to spans in coord::handle_execute_inner, using stmt.to_ast_string_redacted(). In the case of a query with 100000 numbers in a VALUES clause, we'll log 100000 redacted numbers.

There's no point in recording that many redacted values. When we're doing redaction, we'll only log the first 20 values, leaving a comment indicating how many more there ought to be.

(This could be refined: if there are 21 VALUES that are meaningful, non-redacted expressions, we'll drop the last one. We could instead render the first 20 redacted values, and drop them after that. Such a policy would require a bit more nuance than this PR.)

Motivation

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@mgree mgree requested a review from a team as a code owner December 18, 2024 20:31
@mgree mgree requested a review from ParkMyCar December 18, 2024 20:31
Copy link
Member

@ParkMyCar ParkMyCar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgree mgree enabled auto-merge (squash) December 18, 2024 21:55
@mgree mgree merged commit 8fddff2 into MaterializeInc:main Dec 18, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants