[logging] Don't render large VALUES when redacting #30866
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We attach SQL statements to spans in
coord::handle_execute_inner
, usingstmt.to_ast_string_redacted()
. In the case of a query with 100000 numbers in aVALUES
clause, we'll log 100000 redacted numbers.There's no point in recording that many redacted values. When we're doing redaction, we'll only log the first 20 values, leaving a comment indicating how many more there ought to be.
(This could be refined: if there are 21
VALUES
that are meaningful, non-redacted expressions, we'll drop the last one. We could instead render the first 20 redacted values, and drop them after that. Such a policy would require a bit more nuance than this PR.)Motivation
https://github.com/MaterializeInc/database-issues/issues/8832#event-15647939462
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.