Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #30650 from teskje/disable-new-introspecti… #30692

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Revert "Merge pull request #30650 from teskje/disable-new-introspecti… #30692

merged 1 commit into from
Dec 3, 2024

Conversation

jkosh44
Copy link
Contributor

@jkosh44 jkosh44 commented Dec 2, 2024

…on-sources"

This reverts commit a3aafa6, reversing changes made to 33af11a.

Motivation

This PR adds a known-desirable feature.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

benesch
benesch approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI is happy this time around.

@jkosh44
Revert "Merge pull request MaterializeInc#30650 from teskje/disable-n…
9f44b1b 
…ew-introspection-sources"

This reverts commit a3aafa6, reversing
changes made to 33af11a.
@jkosh44 jkosh44 force-pushed the enable-new-introspection-sources-again branch from b7cdc35 to 9f44b1b Compare December 3, 2024 15:49
@jkosh44 jkosh44 marked this pull request as ready for review December 3, 2024 15:49
@jkosh44 jkosh44 requested review from a team as code owners December 3, 2024 15:49
@jkosh44 jkosh44 requested review from ParkMyCar and teskje December 3, 2024 15:49
@jkosh44
Copy link
Contributor Author

jkosh44 commented Dec 3, 2024

Looks like there's a lot of failures in Nightly, but they look unrelated. I rebased and will run again.

https://buildkite.com/materialize/nightly/builds/10594#_

teskje
teskje approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@teskje teskje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@jkosh44
Copy link
Contributor Author

jkosh44 commented Dec 3, 2024

Ok, now the two Nightly failures are existing issues, I'm going to merge.

@jkosh44 jkosh44 enabled auto-merge (squash) December 3, 2024 18:35
@jkosh44 jkosh44 merged commit dd25527 into MaterializeInc:main Dec 3, 2024
220 of 230 checks passed
@jkosh44 jkosh44 deleted the enable-new-introspection-sources-again branch December 3, 2024 18:45
@mgree mgree mentioned this pull request Dec 3, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesch benesch benesch approved these changes

@def- def- def- approved these changes

@teskje teskje teskje approved these changes

@ParkMyCar ParkMyCar Awaiting requested review from ParkMyCar ParkMyCar is a code owner automatically assigned from MaterializeInc/adapter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkosh44 @benesch @def- @teskje