Disable the LIR instrospection sources again #30650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit disables the newly added introspection sources `mz_compute_dataflow_global_ids_per_worker` and `mz_compute_lir_mapping_per_worker`, because Mz's 0dt mechanism is currently not prepared to handle new introspection sources. "Disabling" here means removing the registration of the new `Log` builtins and the `View`s depending on them. The intention is to keep the diff as small as possible, to make this change less risky.
|
I'm going to merge this but not #30649 on a hunch. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR again disables the newly added introspection sources
mz_compute_dataflow_global_ids_per_workerandmz_compute_lir_mapping_per_worker, because Mz's 0dt mechanism is currently not prepared to handle new introspection sources. A fix for the 0dt mechanism was merged (#30603) but has to be reverted because it is suspected of causing panics: https://github.com/MaterializeInc/database-issues/issues/8799Motivation
Tips for reviewer
I just reused my original commit instead of reverting the revert (#30620). I hope that makes no difference.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.