SessionConfiguration Rework
#110
Draft
+1,283
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All helper methods of ATProtocolConfiguration have been transferred to this class.
Adding default implementations.
#Conflicts: # Sources/ATProtoKit/ATProtoKit.docc/Extensions/Lexicons/Models/com.atproto/ComAtprotoLexicon.md
Made "labels" property optional.
Fixed the truncation of "description" to 300 characters.
- Fixed documentation. - Changed "avatarBlob" and "bannerBlob" type to "ComAtprotoLexicon.Repository.UploadBlobOutput?"
- Fixed documentation. - Removed unnecessary variable.
- Removed extra list record check. - Fixed the value assignment of the record's arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe in detail what this Pull Request does and why it’s needed. Include anything the reviewers need to be aware of.
As mentioned in the discussions section below, the goal is to update
SessionConfigurationto be more generic so that developers can implement their own solution for session management.ATProtocolConfigurationwill now strictly be used for app password-related session management. TheSessionConfigurationprotocolwill be used as a base for all forms of session configuration, including OAuth.A legacy
classmay be created for those who still prefer the (soon to be) old way of doing things.Linked Issues
Link any related issues here. Format:
#[number]#99
Type of Change
Checklist:
Screenshots (if applicable)
No response
Additional Notes
No response