Fix 949 #950
Open
Fix 949 #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed unsigned from sqlite as its not supported
Removed duplicate foreign key action added a raise for notImmplementedError for columnize as its customized per Platform anyway
As we are using CONSTRAINT for primary keys we dont need this identifier as well
*increments() data types mpw use column attributes instead of constraints to define the column as a primary key. This standardises using *increments accross all platforms
as migrations table uses increments(“migration_id”).primary() this is an ideal place to test the creation works correctly
Contributor
Author
|
Can you review this please or is there anything else we need to cover with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where using an *increments() colum automatically assigned it as the primary key.
This aligns the
*increments()with all other datatypes that can be used as a primary key or not.There are several datatype tweaks for types that are not supported on that platform.
Notably on Sqlite AUTOINCREMENT is only supported for primary keys. So an exception is raised if
.increments()is used on a column that is not markerd with.primary()I added tests for creating the
migrationsas this is a common usage point for.increments()accross all platformsNote: this is a breaking change for those developers using *incremenrs() as a primary key.
for this case just adding .primary() to the column definition will duplocate current behaviour.