fix: disable rainbow by default and add doc to enable it #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or users to enable rainbow
|
@MaskRay Sorry for introducing the problem. Could you please review this PR, and if it's okay, could you publish a fixed version? Thanks a lot. |
|
CC @wks @frankli0324 |
frankli0324
reviewed
Feb 21, 2025
doc/enable-rainbow-colors.md
Outdated
| "ccls.highlight.rainbow": 10, | ||
| "editor.semanticHighlighting.enabled": true, | ||
| "editor.semanticTokenColorCustomizations": { | ||
| "enabled": true, |
frankli0324
approved these changes
Feb 21, 2025
MaskRay
approved these changes
Feb 23, 2025
MaskRay
pushed a commit
that referenced
this pull request
Feb 23, 2025
The rainbow semantic tokens are disabled by default. See the added doc for details. Follow-up #149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove default color customizations and make rainbow colors opt-in
The color settings introduced in #145 caused issues for some users (see #148).
This PR:
configureDefaults