Proposing Core changes to YTPlaybackFix - #2
Open
AppropriateNet2928 wants to merge 22 commits into
Open
Conversation
Updated version and improved description for clarity.
Added a burst count to track consecutive error recoveries in the YTPlayerViewController. Adjusted retry logic to handle rapid error occurrences more effectively.
Added emergency check flag to manage retry logic more effectively.
Fixed compilation errors by adding missing includes, correcting bracket mismatches, and adding comments.
Removed dependency on mobilesubstrate.
Updated README to clarify playback issue fixes and release information.
…s :)) I have modified the time variables, remade the anti logic thing to be more efficient, removed a useless variable and made the seekToTime logic to be more exact and focused on seeking to the exact time that the error started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have modified the Tweak.xm to have:
The currentVideoMediaTime part received an complete write up to keep two time variables synchronized, gTime is currentVideoMediaTime, meaning the time that the video is at and gSavedTime is gTime. Therefore, gSavedTime is the exact time that the video received the error, and then to return currentVideoMediaTime;
The seekToTime part received a small modification, it just made gSavedTime equal to gTime so we can later use seekToTime like this: seekToTime:gSavedTime, meaning that u seek to the time that the video received the error.
The old anti-loop logic was kinda sus and screamed that it may break at any time, so therefore I removed it and added an simpler anti-loop logic instead, with a simple BOOL variable that has the role to stop the retry logic when it is not needed and to start it when it is needed.
This logic is simpler and has the highest chances of a pozitive result :))
The gBurstCount variable was removed due to it being part of the old anti-loop logic :))