Svg parse viewbox #762
Merged
Svg parse viewbox #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
read the svg viewbox. use this to display the SVG at it's original intended size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVG files read by makelangelo software did not take into account the svg viewbox parameter. This caused some SVG files to load as a tiny dot in the center of the paper.
Previously, the workaround was to run something like
Tools > Fit Image On Paper.This PR reads the viewbox field and uses it to calculate the TCM matrix of each SVG Element to display the image at the author's original size and position. This may still be a dot, but more likely it will be enormous. This is preferable because it preserves more fine detail in curves that might be lost to rounding errors.