Better plotter settings panel (#764)

* removed open/export no longer used by Donatello

* allow resize

* fix error message

* replace container contents instead of adding to

* added "opens" back in for Github CI

src/main/java/com/marginallyclever/makelangelo/MainMenu.java

@@ -536,7 +536,7 @@ private void openPlotterSettings() {
         JDialog dialog = new JDialog(SwingUtilities.getWindowAncestor(this),Translator.get("PlotterSettingsPanel.Title"));
         dialog.add(plotterSettingsPanel);
         dialog.setMinimumSize(new Dimension(350,300));
-        dialog.setResizable(false);
+        dialog.setResizable(true);
         dialog.pack();
 
         app.enableMenuBar(false);

src/main/java/com/marginallyclever/makelangelo/plotter/plottersettings/PlotterSettingsManager.java

@@ -124,7 +124,7 @@ public boolean deleteProfile(String robotUID) {
             profileNames.remove(robotUID);
         }
         catch (Exception e) {
-            logger.error("Failed to delete profile {}. {}", robotUID, e);
+            logger.error("Failed to delete profile {}. ", robotUID, e);
             return true;
         }
         return false;

src/main/java/com/marginallyclever/makelangelo/plotter/plottersettings/PlotterSettingsManagerPanel.java

@@ -132,19 +132,20 @@ private void deleteProfile(String uid) {
 	 */
 	private void changeProfile() {
 		String name = (String)configurationList.getSelectedItem();
-		if(name!=null) {
-			logger.debug("changing profile to {}",name);
-			if(plotterSettingsPanel!=null) {
-				this.remove(plotterSettingsPanel);
-			}
-			plotterSettingsManager.setLastSelectedProfile(name);
-			PlotterSettings plotterSettings = new PlotterSettings(name);
-			plotterSettingsPanel = new PlotterSettingsPanel(plotterSettings);
-			container.add(plotterSettingsPanel,BorderLayout.CENTER);
-			this.revalidate();
-			plotterSettingsPanel.addListener(this::firePlotterSettingsChanged);
-			firePlotterSettingsChanged(plotterSettings);
+		if(name==null) return;
+
+		logger.debug("changing profile to {}",name);
+		if(plotterSettingsPanel!=null) {
+			this.remove(plotterSettingsPanel);
 		}
+		plotterSettingsManager.setLastSelectedProfile(name);
+		PlotterSettings plotterSettings = new PlotterSettings(name);
+		plotterSettingsPanel = new PlotterSettingsPanel(plotterSettings);
+		container.removeAll();
+		container.add(plotterSettingsPanel,BorderLayout.CENTER);
+		this.revalidate();
+		plotterSettingsPanel.addListener(this::firePlotterSettingsChanged);
+		firePlotterSettingsChanged(plotterSettings);
 	}
 
 	/**

src/main/java/module-info.java

@@ -26,17 +26,6 @@
     opens com.marginallyclever.makelangelo.makeart.io;
     opens com.marginallyclever.makelangelo.plotter.plottercontrols;
     opens com.marginallyclever.makelangelo.turtle;
-
-    exports com.marginallyclever.communications;
-    exports com.marginallyclever.convenience.log to ch.qos.logback.core;
-    exports com.marginallyclever.makelangelo;
-    exports com.marginallyclever.makelangelo.makeart;
-    exports com.marginallyclever.makelangelo.makeart.imagefilter;
-    exports com.marginallyclever.makelangelo.makeart.turtletool;
-    exports com.marginallyclever.makelangelo.paper;
-    exports com.marginallyclever.makelangelo.plotter.plottersettings;
-    exports com.marginallyclever.makelangelo.turtle;
-
     opens com.marginallyclever.convenience.noise;
     opens com.marginallyclever.convenience.helpers;
 }