Potential fix for code scanning alert no. 28: Incomplete multi-character sanitization#8
Open
manucian-official wants to merge 2 commits into
Open
Potential fix for code scanning alert no. 28: Incomplete multi-character sanitization#8manucian-official wants to merge 2 commits into
manucian-official wants to merge 2 commits into
Conversation
…ter sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: l2k <khoigaming2102pro@gmail.com>
This was
linked to
issues
May 17, 2026
Open
manucian-official
marked this pull request as ready for review
May 17, 2026 13:27
Signed-off-by: l2k <khoigaming2102pro@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/ManucianTeam/Adaptive-Shield-Firewall-ASF-/security/code-scanning/28
Best fix (without changing overall intent): make sanitization iterative to a fixed point so newly exposed
on...substrings are removed in subsequent passes. Keep the same sanitization rules and order, but apply them repeatedly until no changes occur.In
apps/gateway/src/interceptors/sanitize.interceptor.ts, updatesanitizeStringto:value;do { ... } while (sanitized !== previous);loop;No new imports or dependencies are required.