Repository navigation
[fix] Adapt search engine-specific PSM readers to new convention in _load_file - #452
Merged
Merged
Conversation
lucas-diedrich
force-pushed
the
fix/psm-nan-handling-2_adapt-reader
branch
from
September 15, 2026 07:03
9b2857f to
4601b1d
Compare
This reverts commit 6b0571a.
lucas-diedrich
force-pushed
the
fix/psm-nan-handling-2_adapt-reader
branch
from
September 15, 2026 10:45
9793107 to
7925228
Compare
lucas-diedrich
requested review from
mschwoer
and removed request for
mschwoer
September 15, 2026 10:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt individual readers to the convention introduced in #451
I think we can drop the reader-specific
_load_filecalls most of the time as the base reader basically covers these use cases already.