Repository navigation
Support multi-level aggregation 1 | Streamline definition of PsmDfCols keys - #359
Merged
Merged
Conversation
[VERSION] Bump version to 1.7.3
…are-next-version [VERSION] Bump version to 1.7.4-dev0 (merge after release)
Collaborator
Author
|
Currently updated definitions Missing definitions
|
lucas-diedrich
marked this pull request as ready for review
October 29, 2025 16:10
…(identifier + intensities/values)
vbrennsteiner
approved these changes
Oct 29, 2025
vbrennsteiner
left a comment
Contributor
There was a problem hiding this comment.
LGTM save for missing documentations, but in general I would not spend too much time digging them up, but instead wait until use-cases appear for the more obscure columns like "TO_REMOVE", "AA_MASS_DIFFS" and "A_MASS_DIFF_SITES".
mschwoer
reviewed
Oct 29, 2025
Support multi-level aggregation 3 | Add configuration of new keys for DIANN
…(identifier + intensities/values)
…phabase into add-missing-psm-keys
Support multi-level aggregation 2 | Add missing column keys
… of every single parameter
…(identifier + intensities/values)
…(identifier + intensities/values)
…nnLabs/alphabase into streamline-psm-col-definition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to MannLabs/alphapepttools#99 (comment)
This PR only adds definitions for each Key in the PsmDfCols Metaclass. In a next step, column mappings can be updated based on these standardized defintions.