Allowing Swap to accept Group and VGroup and add Example#4211
Open
irvanalhaq9 wants to merge 1 commit intoManimCommunity:mainfrom
Open
Allowing Swap to accept Group and VGroup and add Example#4211irvanalhaq9 wants to merge 1 commit intoManimCommunity:mainfrom
Swap to accept Group and VGroup and add Example#4211irvanalhaq9 wants to merge 1 commit intoManimCommunity:mainfrom
Conversation
| RendererType, | ||
| ) | ||
| from ..mobject.mobject import Group, Mobject | ||
| from ..mobject.types.vectorized_mobject import VGroup |
Check notice
Code scanning / CodeQL
Cyclic import
9ee7932 to
0873d68
Compare
0873d68 to
2393d6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Fix #4210
This PR modifies
CyclicReplace(whichSwapis an alias for) to allow it to acceptGrouporVGroupdirectly, instead of always creating a new group internally.Motivation and Explanation: Why and how do your changes improve the library?
Previously,
CyclicReplacewould create a new group from the given mobjects, making the previously created group unrecognized byself.remove(). Now, if aGrouporVGroupis passed, it will be used directly rather than creating a new one.This ensures that the original group remains in the scene, making it possible to remove it later if needed.
Example:
With this fix, the following code will now correctly remove
text_groupfrom the scene:Links to added or changed documentation pages
https://manimce--4211.org.readthedocs.build/en/4211/reference/manim.animation.transform.Swap.html
Reviewer Checklist