Skip to content

Rename update function dot_position to update_label in .add_updater example #4196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

irvanalhaq9
Copy link
Contributor

@irvanalhaq9 irvanalhaq9 commented Mar 20, 2025

Overview: What does this pull request change?

Renamed update function dot_position to update_label in .add_updater example.

Motivation and Explanation: Why and how do your changes improve the library?

  • The previous function name dot_position was misleading because it suggested updating the dot's position.
  • The function actually updates the label's value and the label's position.
  • Renaming it to update_label improves clarity and better reflects its purpose.

Links to added or changed documentation pages

https://manimce--4196.org.readthedocs.build/en/4196/reference/manim.mobject.mobject.Mobject.html#manim.mobject.mobject.Mobject.add_updater

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@irvanalhaq9 irvanalhaq9 force-pushed the rename-dot_position-to-update_label branch from 75ff4ee to 00b1488 Compare April 20, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

1 participant