Skip to content

Add Node Affinity arch selector based on the affinity of the orchestrator #22757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2023
Merged

Add Node Affinity arch selector based on the affinity of the orchestrator #22757

merged 1 commit into from
Oct 30, 2023

Conversation

@bdunne
Copy link
Member

@bdunne bdunne commented Oct 26, 2023 •
edited
Loading

Related to: ManageIQ/manageiq-pods#1003

Note: This will also apply to the workflow pods.

@bdunne bdunne requested a review from Fryguy as a code owner October 26, 2023 22:45
bdunne
bdunne commented Oct 26, 2023
View reviewed changes
lib/container_orchestrator.rb
i.matchExpressions&.each { |a| return(a.values) if a.key == "kubernetes.io/arch" }
end

return ["amd64"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the same default value in the operator. I'm not sure if it's better to have a default or not set the affinity at all.

@Fryguy Fryguy closed this Oct 27, 2023
@Fryguy Fryguy reopened this Oct 27, 2023
@Fryguy Fryguy merged commit 90989d7 into ManageIQ:master Oct 30, 2023
@bdunne bdunne deleted the node_affinity branch October 30, 2023 21:37
@bdunne bdunne mentioned this pull request Oct 30, 2023
Closed
@Fryguy
Copy link
Member

Fryguy commented Oct 31, 2023

Backported to quinteros in commit cf43b19.

commit cf43b191d13a0d0b8856ea5515cf88c92455d4fd
Author: Jason Frey <[email protected]>
Date:   Mon Oct 30 15:50:53 2023 -0400

    Merge pull request #22757 from bdunne/node_affinity
    
    Add Node Affinity arch selector based on the affinity of the orchestrator
    
    (cherry picked from commit 90989d742d720f039222bf2638fa5636b61fedbb)

Fryguy added a commit that referenced this pull request Oct 31, 2023
@Fryguy
Merge pull request #22757 from bdunne/node_affinity
cf43b19 
Add Node Affinity arch selector based on the affinity of the orchestrator

(cherry picked from commit 90989d7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

Assignees

@Fryguy Fryguy

Labels

enhancement quinteros/backported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bdunne @Fryguy